You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/26 15:50:31 UTC

[GitHub] [accumulo] keith-turner commented on pull request #1950: Clean up CompactionDirectives default impl

keith-turner commented on pull request #1950:
URL: https://github.com/apache/accumulo/pull/1950#issuecomment-786728859


   CompactionDispatcher and CompactionDirective follow the same pattern as [ScanDispatcher](https://github.com/apache/accumulo/blob/main/core/src/main/java/org/apache/accumulo/core/spi/scan/ScanDispatcher.java) and [ScanDirective](https://github.com/apache/accumulo/blob/main/core/src/main/java/org/apache/accumulo/core/spi/scan/ScanDispatcher.java).  In my opinion it would be good to keep them consistent.  ScanDispatcher used to return a single string for its dispatch method in 2.0.0.  Then in 2.1.0 cache information was added to the scan dispatch method resulting in the need to return an object.  That is why I chose to start off returning an object for the compaction dispatch method.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org