[GitHub] sijie commented on a change in pull request #1774: Removed multifunction.jar from sources

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1774: Removed multifunction.jar from sources
URL: https://github.com/apache/incubator-pulsar/pull/1774#discussion_r188040395
 
 

 ##########
 File path: pulsar-functions/utils/src/test/java/org/apache/pulsar/functions/utils/functioncache/FunctionClassLoadersTest.java
 ##########
 @@ -34,23 +35,24 @@
 
     @Test
     public void testCreateClassLoader() throws Exception {
-        URL jarUrl = getClass().getClassLoader().getResource("multifunction.jar");
+        URL jarUrl = FileSystems.getDefault()
 
 Review comment:
   with this change, the tests are not accurate anymore. at the moment you are adding source files or including it as a dependency, those classes are already loaded by the class loader. That says `AddFunction` is loaded by `getClass().getClassLoader()`. this doesn't really test the user-defined jar anymore.
   
   so I would suggest just remove multifunctions.jar and its related test cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services