You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/18 15:30:11 UTC
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4774: Added configuration and Integration test to restrict public template …
weizhouapache commented on a change in pull request #4774:
URL: https://github.com/apache/cloudstack/pull/4774#discussion_r810103090
##########
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##########
@@ -111,8 +111,8 @@
"allow.user.view.all.domain.accounts", "false",
"Determines whether users can view all user accounts within the same domain", true, ConfigKey.Scope.Domain);
- static final ConfigKey<Boolean> RestrictPublicTemplatesOfOtherDomains = new ConfigKey<>("Advanced", Boolean.class, "restrict.public.templates.of.other.domains", "false",
- "If true, the public templates of other domains will not be visible in this domain.", true, ConfigKey.Scope.Domain);
+ static final ConfigKey<Boolean> SharePublicTemplates = new ConfigKey<>("Advanced", Boolean.class, "share.public.templates", "true",
+ "If false, templates of this domain with not show up in the list templates.", true, ConfigKey.Scope.Domain);
Review comment:
with or will ?
##########
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##########
@@ -111,8 +111,8 @@
"allow.user.view.all.domain.accounts", "false",
"Determines whether users can view all user accounts within the same domain", true, ConfigKey.Scope.Domain);
- static final ConfigKey<Boolean> RestrictPublicTemplatesOfOtherDomains = new ConfigKey<>("Advanced", Boolean.class, "restrict.public.templates.of.other.domains", "false",
- "If true, the public templates of other domains will not be visible in this domain.", true, ConfigKey.Scope.Domain);
+ static final ConfigKey<Boolean> SharePublicTemplates = new ConfigKey<>("Advanced", Boolean.class, "share.public.templates", "true",
Review comment:
maybe add more content to configuration name ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org