[jira] [Commented] (HDFS-8607) TestFileCorruption doesn't work as expected

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585912#comment-14585912 ] 

Hadoop QA commented on HDFS-8607:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |   5m 42s | Findbugs (version ) appears to be broken on trunk. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 31s | There were no new javac warning messages. |
| {color:green}+1{color} | release audit |   0m 20s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 50s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 31s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   3m 16s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native |   1m 20s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 161m 34s | Tests passed in hadoop-hdfs. |
| | | 182m 43s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12739586/HDFS-8607.01.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 4c5da9b |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11357/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11357/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11357/console |


This message was automatically generated.

> TestFileCorruption doesn't work as expected
> -------------------------------------------
>
>                 Key: HDFS-8607
>                 URL: https://issues.apache.org/jira/browse/HDFS-8607
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Walter Su
>            Assignee: Walter Su
>         Attachments: HDFS-8607.01.patch
>
>
> Although it passes, it's useless.
> {code}
>  77  File[] blocks = data_dir.listFiles();
>  78  assertTrue("Blocks do not exist in data-dir", (blocks != null) && (blocks.length > 0));
>  79  for (int idx = 0; idx < blocks.length; idx++) {
>  80    if (!blocks[idx].getName().startsWith(Block.BLOCK_FILE_PREFIX)) {
>  81      continue;
>  82    }
>  83    System.out.println("Deliberately removing file "+blocks[idx].getName());
>  84    assertTrue("Cannot remove file.", blocks[idx].delete());
>  85  }
> {code}
> blocks are located at finalized/subdir0/subdir0, but line 77 only returns "subdir0" because {{File.listFiles()}} is not recursive. So line 83~84 will never be excuted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)