You are viewing a plain text version of this content. The canonical link for it is here.

Posted to solr-dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2009/04/25 09:31:30 UTC

[jira] Created: (SOLR-1129) SolrJ cannot bind dynamic fields to beans

SolrJ cannot bind dynamic fields to beans
-----------------------------------------

                 Key: SOLR-1129
                 URL: https://issues.apache.org/jira/browse/SOLR-1129
             Project: Solr
          Issue Type: Improvement
          Components: clients - java
    Affects Versions: 1.3
            Reporter: Noble Paul


SolrJ does not support binding of dynamic fields to bean fields

The field declaration could be as follows
{code:java}

@Field("*_s")
public String anyString;
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SOLR-1129) SolrJ cannot bind dynamic fields to beans

Posted by "Avlesh Singh (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/SOLR-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702987#action_12702987 ] 

Avlesh Singh commented on SOLR-1129:
------------------------------------

All you points are taken, Noble.
I'll make the modifications in trunk and get back asap.

> SolrJ cannot bind dynamic fields to beans
> -----------------------------------------
>
>                 Key: SOLR-1129
>                 URL: https://issues.apache.org/jira/browse/SOLR-1129
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>         Attachments: SOLR-1129.patch
>
>
> SolrJ does not support binding of dynamic fields to bean fields
> The field declaration could be as follows
> {code:java}
> @Field("*_s")
> public String anyString;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SOLR-1129) SolrJ cannot bind dynamic fields to beans

Posted by "Avlesh Singh (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SOLR-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Avlesh Singh updated SOLR-1129:
-------------------------------

    Attachment: SOLR-1129.patch

All the changes as discussed earlier, have been implemented.
SolrJ can now be used to bind dynamic fields using any one of these

{code:java}
@Field("*_random")
public Map<String, Integer> random;

@Field("categories_*")
public Map<String, String[]> categories;

@Field("oem_*")
public Map<String, List<String>> oem;

@Field("supplier_*")
public List<String> allSuppliers;

@Field("supplier_*")
public String supplier;

@Field("supplier_*")
public void setSuppliers(String[] allSuppliers){}
{code}

The attached patch also contains a test case for the above mentioned usages. 

Cheers
Avlesh

> SolrJ cannot bind dynamic fields to beans
> -----------------------------------------
>
>                 Key: SOLR-1129
>                 URL: https://issues.apache.org/jira/browse/SOLR-1129
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1129.patch, SOLR-1129.patch
>
>
> SolrJ does not support binding of dynamic fields to bean fields
> The field declaration could be as follows
> {code:java}
> @Field("*_s")
> public String anyString;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SOLR-1129) SolrJ cannot bind dynamic fields to beans

Posted by "Avlesh Singh (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/SOLR-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702675#action_12702675 ] 

Avlesh Singh commented on SOLR-1129:
------------------------------------

Thanks for creating this ticket, Noble.

I have an issue with the approach you have mentioned. IMO, the client should specify the "field" to which the value belongs to.
I would rather prefer a format like this -  
{code:java}
@Field("*_s")
public Map<String, Object> foo;
{code}

where the keys are {{dynamicField}} name's. For {{multivalued}} fields, a user might specify an {{Object[]}} as value.

> SolrJ cannot bind dynamic fields to beans
> -----------------------------------------
>
>                 Key: SOLR-1129
>                 URL: https://issues.apache.org/jira/browse/SOLR-1129
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>
> SolrJ does not support binding of dynamic fields to bean fields
> The field declaration could be as follows
> {code:java}
> @Field("*_s")
> public String anyString;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SOLR-1129) SolrJ cannot bind dynamic fields to beans

Posted by "Avlesh Singh (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SOLR-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Avlesh Singh updated SOLR-1129:
-------------------------------

    Attachment: SOLR-1129.patch

Adding a patch for this enhancement. 
Existing test cases pass. I'll add new test cases in {{TestDocumentObjectBinder}} shortly.

This is the approach I took.
# Dynamic fields can be annotated in the following manner
{code:java}
@Field("*_random")
public Map<String, Integer> random;

@Field("supplier_*")
public Map<String, String[]> suppliers;

@Field("oem_*")
public Map<String, List<String>> oem;
{code}
# Based on the {{value type}} of this {{Map}}, I populate all matching fields in the response with their corresponding value(s).
# I added one more clause to the {{DocField}}'s {{storeType}} method to take care of fields of type {{Map}}. Using {{getActualTypeArguments}} for this {{ParameterizedType}} value, I populate the existing properties in the {{DocField}} viz {{name, field, type, isArray, isList}} etc.
# I added a private method, {{getFieldValueByFieldName(SolrDocument sdoc, String fieldName)}} in the {{DocField}} class, which is now  being called by the {{inject}} method for all fields. For regular index fields, the method behavior has not changed. However, for a dynamic field (as annotated by the client), this method prepares a {{Map}} of matching fieldNames and their corresponding value(s). This in turn is used by the {{inject}} method to call the client bean's corresponding setter method.

Please note that this fix is for version 1.3.

Cheers
Avlesh

> SolrJ cannot bind dynamic fields to beans
> -----------------------------------------
>
>                 Key: SOLR-1129
>                 URL: https://issues.apache.org/jira/browse/SOLR-1129
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>         Attachments: SOLR-1129.patch
>
>
> SolrJ does not support binding of dynamic fields to bean fields
> The field declaration could be as follows
> {code:java}
> @Field("*_s")
> public String anyString;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SOLR-1129) SolrJ cannot bind dynamic fields to beans

Posted by "Anders Hessellund Jensen (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/SOLR-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747964#action_12747964 ] 

Anders Hessellund Jensen commented on SOLR-1129:
------------------------------------------------

The patch only addresses binding of dynamic fields  in one direction, that is, converting documents to beans. The other direction, converting beans to documents, does not work. Attempting to index a bean with dynamic fields using the SolrServer.addBean() method does fails to correctly index the dynamic fields.

> SolrJ cannot bind dynamic fields to beans
> -----------------------------------------
>
>                 Key: SOLR-1129
>                 URL: https://issues.apache.org/jira/browse/SOLR-1129
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1129.patch, SOLR-1129.patch, SOLR-1129.patch, SOLR-1129.patch, SOLR-1129.patch, SOLR-1129.patch
>
>
> SolrJ does not support binding of dynamic fields to bean fields
> The field declaration could be as follows
> {code:java}
> @Field("*_s")
> public String anyString;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SOLR-1129) SolrJ cannot bind dynamic fields to beans

Posted by "Avlesh Singh (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SOLR-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Avlesh Singh updated SOLR-1129:
-------------------------------

    Attachment: SOLR-1129.patch

Just realized that the usage of {{field.matches("^"fieldName"$")}} has not been changed to use the cached pattern. Made the necessary change. Please use the latest patch.

> SolrJ cannot bind dynamic fields to beans
> -----------------------------------------
>
>                 Key: SOLR-1129
>                 URL: https://issues.apache.org/jira/browse/SOLR-1129
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1129.patch, SOLR-1129.patch, SOLR-1129.patch
>
>
> SolrJ does not support binding of dynamic fields to bean fields
> The field declaration could be as follows
> {code:java}
> @Field("*_s")
> public String anyString;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SOLR-1129) SolrJ cannot bind dynamic fields to beans

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SOLR-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-1129:
----------------------------------------

    Fix Version/s: 1.4

Marking for 1.4 as this is a serious deficiency.

> SolrJ cannot bind dynamic fields to beans
> -----------------------------------------
>
>                 Key: SOLR-1129
>                 URL: https://issues.apache.org/jira/browse/SOLR-1129
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1129.patch
>
>
> SolrJ does not support binding of dynamic fields to bean fields
> The field declaration could be as follows
> {code:java}
> @Field("*_s")
> public String anyString;
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.