[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

["Rakesh Midha (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Rakesh Midha updated GERONIMO-1642:
-----------------------------------

    Attachment: namespace1642.patch


I tried this and found following results
-------------------------------------------------------------
for geronimo-web.xml
------------------------------
It gives Error: Unable to distribute myphonebook-web.war: Cannot handle web
plan with namespace http://geronimo.apache.org/xml/ns/j2ee/web-1.21
-- expecting http://geronimo.apache.org/xml/ns/j2ee/web-1.2 or
http://geronimo.apache.org/xml/ns/j2ee/web/tomcat-1.2

I think it was fixed in revision 406804

for geronimo-ra.xml
-----------------------------
It gives error: The document is not a
    connector@http://geronimo.apache.org/xml/ns/j2ee/connector-1.2:
    document element namespace mismatch expected
    "http://geronimo.apache.org/xml/ns/j2ee/connector-1.2" got
    "http://geronimo.apache.org/xml/ns/j2ee/connector-1.1a"

Again it is fixed

geronimo-application.xml, openejb-jar.xml and application-client
------------------------------------------------------------------------------------------
It is a problem mentioned in JIRA

-----------------------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------------------
The attached patch tries to fix it in generic way using SchemaConversionUtils.java

It tries to check for wrong element or namespace and instead of returning null, it throws XmlException with message 
Cannot find desiredElement "application" with
    namespace{http://geronimo.apache.org/xml/ns/j2ee/application-1.2} in
    the plan provided.

So after applying patch, geronimo-application.xml, openejb-jar.xml and application-client
gives required error msg -->
Cannot find desiredElement "application" with
    namespace{http://geronimo.apache.org/xml/ns/j2ee/application-1.2} in
    the plan provided.

I hope this is what is desired.

Thanks

> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: deployment, OpenEJB, web
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>         Assigned To: Rakesh Midha
>            Priority: Critical
>             Fix For: 1.1.x
>
>         Attachments: namespace1642.patch
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira