You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/09/13 18:48:49 UTC

[kudu-CR] Update instructions for publishing changes to the live site 

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/8059

to review the following change.

Change subject: Update instructions for publishing changes to the live site
......................................................................

Update instructions for publishing changes to the live site

Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
---
M README.adoc
1 file changed, 21 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/8059/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
......................................................................


Patch Set 2:

> what do you think about moving the entire section out of README.md to RELEASING.md?  It may fit better there

That document basically assumes we are doing a full release, while updating the docs can be done out-of-cycle, so it doesn't really seem to mesh that well to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:30:26 +0000
Gerrit-HasComments: No

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
......................................................................


Patch Set 2: Code-Review+2

OK SGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:37:33 +0000
Gerrit-HasComments: No

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8059/1/README.adoc
File README.adoc:

http://gerrit.cloudera.org:8080/#/c/8059/1/README.adoc@348
PS1, Line 348: cd _publish && git push  # Update the live web site.
> May want to add a note about having to push an empty commit if the change i
Good call, done



-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:11:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has removed a vote on this change.

Change subject: Update instructions for publishing changes to the live site
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:15:00 +0000
Gerrit-HasComments: No

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8059

to look at the new patch set (#2).

Change subject: Update instructions for publishing changes to the live site
......................................................................

Update instructions for publishing changes to the live site

Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
---
M README.adoc
1 file changed, 26 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/8059/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: Update instructions for publishing changes to the live site
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8059/1/README.adoc
File README.adoc:

Line 348: cd _publish && git push  # Update the live web site.
May want to add a note about having to push an empty commit if the change is large in order to work around a bug in the ASF gitpubsub


-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
......................................................................


Patch Set 2:

Text looks good to me, but what do you think about moving the entire section out of README.md to RELEASING.md?  It may fit better there


-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 00:15:07 +0000
Gerrit-HasComments: No

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Update instructions for publishing changes to the live site
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Update instructions for publishing changes to the live site

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8059 )

Change subject: Update instructions for publishing changes to the live site
......................................................................

Update instructions for publishing changes to the live site

Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Reviewed-on: http://gerrit.cloudera.org:8080/8059
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Mike Percy <mp...@apache.org>
---
M README.adoc
1 file changed, 26 insertions(+), 1 deletion(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Mike Percy: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fc1a40d6deedf8eb1a9d8e6d13f803f6109c06b
Gerrit-Change-Number: 8059
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>