You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/24 06:01:45 UTC
[GitHub] [druid] vogievetsky edited a comment on pull request #11908: Improve the output of SQL explain message
vogievetsky edited a comment on pull request #11908:
URL: https://github.com/apache/druid/pull/11908#issuecomment-977557250
Very excited for this change! I got 2 questions:
(1) is it possible to provide the signature as JSON and not as a string?
instead of `"signature": "{d0:STRING, a0:LONG}"`
provide it as `"signature": [{name: "d0", "type":"STRING"}, {"name":"a0", "type":"LONG"}]`
the signature strings are really annoying to parse and these signatures are really important (sometimes more so than the query)
(2) you included screenshots of the old format in the console query view, but how does it work with the explain dialog? Does it need to be updated as part of this PR or right afterwards?
Just to be clear I am talking about this dialog:
As you can see the current dialog parses the old format thus relying on it. I would LOVE nothing more than to switch to this new format (providing pt.1) but does this PR break this dialog? Ideally there would be a context flag to trigger the new format but the old format would be the default (at least for a few releases).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org