You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by agneya2001 <gi...@git.apache.org> on 2016/01/04 12:01:31 UTC

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

GitHub user agneya2001 opened a pull request:

    https://github.com/apache/cloudstack/pull/1303

    QuotaStatementTest: fix the method invocation verification

    Quota emails are send at start of the month, that triggered the sendQuotaAlert that was not getting invoked earlier.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack master-quota-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1303
    
----
commit c9296c5cd91c710a079e4e482e7f83ab52c26cec
Author: Abhinandan Prateek <ab...@shapeblue.com>
Date:   2016-01-04T10:58:42Z

    QuotaStatementTest: fix the method invocation verification

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1303#issuecomment-168653465
  
    LGTM, let's wait for Jenkins to finish (if it does not fail due to JVM issues)
    cc @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1303#issuecomment-169008756
  
    @DaanHoogland Quota is not in 4.6 afaik.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1303#issuecomment-169002502
  
    jenkins passed this one, please point to 4.6 if it contains the problem as well ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1303#issuecomment-168663983
  
    Please point the PR to 4.7 branch, as this suffers from the same issue. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1303#issuecomment-169016186
  
    @agneya2001 Please close this PR as #1306 is already merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Posted by agneya2001 <gi...@git.apache.org>.
Github user agneya2001 closed the pull request at:

    https://github.com/apache/cloudstack/pull/1303


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---