[GitHub] [superset] naharoo commented on issue #16246: [Helm Chart] redis password not set for celery brokers

[GitBox <gi...@apache.org>]

naharoo commented on issue #16246:
URL: https://github.com/apache/superset/issues/16246#issuecomment-1172014737

   The issue causing this behavior is this snippet from the Helm chart. 
   ```
   class CeleryConfig(object):
     CELERY_IMPORTS = ('superset.sql_lab', )
     CELERY_ANNOTATIONS = {'tasks.add': {'rate_limit': '10/s'}}
   {{- if .Values.supersetNode.connections.redis_password }}
     BROKER_URL = f"redis://:{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
     CELERY_RESULT_BACKEND = f"redis://:{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
   {{- else }}
     BROKER_URL = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
     CELERY_RESULT_BACKEND = f"redis://{env('REDIS_HOST')}:{env('REDIS_PORT')}/0"
   {{- end }}
   ```
   It basically checks whether `supersetNode.connections.redis_password` is provided or not and includes the password in redis url based on that.
   
   We can work around this with just providing a dummy value to `redis_password` helm configuration property and overriding it with the env variable `REDIS_PASSWORD`. 
   ```
   supersetNode:
     connections:
       redis_password: "dummy-placeholder"
   ```
   ```
   extraEnvRaw:
     - name: "REDIS_PASSWORD"
       valueFrom:
         secretKeyRef:
           name: "redis-credentials"
           key: "password"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org