[GitHub] [helix] pkuwm commented on a change in pull request #1609: Include Exception Message in Log of ZkBaseDataAccessor#get()

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #1609:
URL: https://github.com/apache/helix/pull/1609#discussion_r556176552



##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
##########
@@ -568,7 +568,8 @@ public T get(String path, Stat stat, int options) {
       }
       return records;
     } catch (Exception e) {
-      throw new HelixMetaDataAccessException(String.format("Fail to read nodes for %s", paths));
+      throw new HelixMetaDataAccessException(
+          String.format("Fail to read nodes for %s, err: %s", paths, e.getMessage()));

Review comment:
       How about including the whole exception as the cause for `HelixMetaDataAccessException`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org