You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Pierre Cheynier <me...@pierre-cheynier.net> on 2016/03/24 18:51:11 UTC
Review Request 45298: Remove some dependencies linked to docker usage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora-packaging
Description
-------
An operator should be able to build Aurora on his platform without
relying on Docker.
Even if this is an interesting way of doing it, it sometimes introduce missed
(build-)dependencies (in this case openssl) and context-specific behaviour
(here, the way pants.ini was added to the build context)
Diffs
-----
README.md 3a7cf45034b7896c23588fed83176468ca627ebc
builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f
builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b
builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4
builder/deb/ubuntu-trusty/pants.ini
builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d
builder/rpm/centos-7/pants.ini
specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a
specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d
specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25
Diff: https://reviews.apache.org/r/45298/diff/
Testing
-------
Able to build on CentOS 6 using mock.
Able to build on Debian. Limitation = need the patched version of Gradle.
Still able to build using the current Docker build system
Thanks,
Pierre Cheynier
Re: Review Request 45298: Remove some dependencies linked to docker
usage
Posted by Pierre Cheynier <me...@pierre-cheynier.net>.
> On mars 24, 2016, 6:04 après-midi, John Sirois wrote:
> > specs/rpm/aurora.spec, line 146
> > <https://reviews.apache.org/r/45298/diff/1/?file=1314067#file1314067line146>
> >
> > This breaks the release script, you can try something like this - it needs to run green: `./build-artifact.sh /tmp/apache-aurora-0.12.0.tar.gz 0.12.0`
>
> Pierre Cheynier wrote:
> Hi John.
> This is why I edited the README (AFAIK, this is a pure naming convention introduced by the README).
>
> I changed it to be able to make the aurora.spec work (see Source0 : it fetch Aurora sources from github).
Let me know, maybe it was not the good approach. I was initially wondering why I was not able to simply build the RPM with spectool + mock (= fetch sources + rpmbuild in a chrooted context).
- Pierre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
-----------------------------------------------------------
On mars 24, 2016, 6:04 après-midi, Pierre Cheynier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
>
> (Updated mars 24, 2016, 6:04 après-midi)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> An operator should be able to build Aurora on his platform without
> relying on Docker.
>
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
>
>
> Diffs
> -----
>
> README.md 3a7cf45034b7896c23588fed83176468ca627ebc
> builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f
> builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b
> builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4
> builder/deb/ubuntu-trusty/pants.ini
> builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d
> builder/rpm/centos-7/pants.ini
> specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a
> specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d
> specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25
>
> Diff: https://reviews.apache.org/r/45298/diff/
>
>
> Testing
> -------
>
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
>
>
> Thanks,
>
> Pierre Cheynier
>
>
Re: Review Request 45298: Remove some dependencies linked to docker
usage
Posted by John Sirois <js...@apache.org>.
> On March 24, 2016, 12:04 p.m., John Sirois wrote:
> > specs/rpm/aurora.spec, line 146
> > <https://reviews.apache.org/r/45298/diff/1/?file=1314067#file1314067line146>
> >
> > This breaks the release script, you can try something like this - it needs to run green: `./build-artifact.sh /tmp/apache-aurora-0.12.0.tar.gz 0.12.0`
>
> Pierre Cheynier wrote:
> Hi John.
> This is why I edited the README (AFAIK, this is a pure naming convention introduced by the README).
>
> I changed it to be able to make the aurora.spec work (see Source0 : it fetch Aurora sources from github).
>
> Pierre Cheynier wrote:
> Let me know, maybe it was not the good approach. I was initially wondering why I was not able to simply build the RPM with spectool + mock (= fetch sources + rpmbuild in a chrooted context).
Gotcha. The failure I got was from using the official released sources, ie: this bit of the README:
> Fetch a source distribution, such as an [official one](https://aurora.apache.org/downloads/).
So that portion of the README needscan update.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
-----------------------------------------------------------
On March 24, 2016, 12:04 p.m., Pierre Cheynier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:04 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> An operator should be able to build Aurora on his platform without
> relying on Docker.
>
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
>
>
> Diffs
> -----
>
> README.md 3a7cf45034b7896c23588fed83176468ca627ebc
> builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f
> builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b
> builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4
> builder/deb/ubuntu-trusty/pants.ini
> builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d
> builder/rpm/centos-7/pants.ini
> specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a
> specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d
> specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25
>
> Diff: https://reviews.apache.org/r/45298/diff/
>
>
> Testing
> -------
>
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
>
>
> Thanks,
>
> Pierre Cheynier
>
>
Re: Review Request 45298: Remove some dependencies linked to docker
usage
Posted by John Sirois <js...@apache.org>.
> On March 24, 2016, 12:04 p.m., John Sirois wrote:
> > Right now the working operation of `./build-artifact.sh` for consistent releases is paramount and use of this repo to make custom builds is secondary. The rpm `%setup -n ...` has gone back and forth once already due to breaking our release process so I'll need you to dig in further and get the builds working both via `./build-artifact.sh` and for a raw build.
And ideally you could add a test of the non-container build or else your fixes will invariably bit-rot (we have nightly Jenkins verification that `./build-artifact.sh` works).
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
-----------------------------------------------------------
On March 24, 2016, 12:04 p.m., Pierre Cheynier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:04 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> An operator should be able to build Aurora on his platform without
> relying on Docker.
>
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
>
>
> Diffs
> -----
>
> README.md 3a7cf45034b7896c23588fed83176468ca627ebc
> builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f
> builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b
> builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4
> builder/deb/ubuntu-trusty/pants.ini
> builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d
> builder/rpm/centos-7/pants.ini
> specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a
> specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d
> specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25
>
> Diff: https://reviews.apache.org/r/45298/diff/
>
>
> Testing
> -------
>
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
>
>
> Thanks,
>
> Pierre Cheynier
>
>
Re: Review Request 45298: Remove some dependencies linked to docker
usage
Posted by Pierre Cheynier <me...@pierre-cheynier.net>.
> On mars 24, 2016, 6:04 après-midi, John Sirois wrote:
> > specs/rpm/aurora.spec, line 146
> > <https://reviews.apache.org/r/45298/diff/1/?file=1314067#file1314067line146>
> >
> > This breaks the release script, you can try something like this - it needs to run green: `./build-artifact.sh /tmp/apache-aurora-0.12.0.tar.gz 0.12.0`
Hi John.
This is why I edited the README (AFAIK, this is a pure naming convention introduced by the README).
I changed it to be able to make the aurora.spec work (see Source0 : it fetch Aurora sources from github).
- Pierre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
-----------------------------------------------------------
On mars 24, 2016, 6:04 après-midi, Pierre Cheynier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
>
> (Updated mars 24, 2016, 6:04 après-midi)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> An operator should be able to build Aurora on his platform without
> relying on Docker.
>
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
>
>
> Diffs
> -----
>
> README.md 3a7cf45034b7896c23588fed83176468ca627ebc
> builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f
> builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b
> builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4
> builder/deb/ubuntu-trusty/pants.ini
> builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d
> builder/rpm/centos-7/pants.ini
> specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a
> specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d
> specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25
>
> Diff: https://reviews.apache.org/r/45298/diff/
>
>
> Testing
> -------
>
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
>
>
> Thanks,
>
> Pierre Cheynier
>
>
Re: Review Request 45298: Remove some dependencies linked to docker
usage
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review125302
-----------------------------------------------------------
Right now the working operation of `./build-artifact.sh` for consistent releases is paramount and use of this repo to make custom builds is secondary. The rpm `%setup -n ...` has gone back and forth once already due to breaking our release process so I'll need you to dig in further and get the builds working both via `./build-artifact.sh` and for a raw build.
specs/rpm/aurora.spec (line 146)
<https://reviews.apache.org/r/45298/#comment188086>
This breaks the release script, you can try something like this - it needs to run green: `./build-artifact.sh /tmp/apache-aurora-0.12.0.tar.gz 0.12.0`
- John Sirois
On March 24, 2016, 11:51 a.m., Pierre Cheynier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 11:51 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> An operator should be able to build Aurora on his platform without
> relying on Docker.
>
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
>
>
> Diffs
> -----
>
> README.md 3a7cf45034b7896c23588fed83176468ca627ebc
> builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f
> builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b
> builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4
> builder/deb/ubuntu-trusty/pants.ini
> builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d
> builder/rpm/centos-7/pants.ini
> specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a
> specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d
> specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25
>
> Diff: https://reviews.apache.org/r/45298/diff/
>
>
> Testing
> -------
>
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
>
>
> Thanks,
>
> Pierre Cheynier
>
>