You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2026/05/20 09:53:17 UTC

[PR] workflow: support specifying a single image for nightly E2E operation workflow [shardingsphere]

sandynz opened a new pull request, #38708:
URL: https://github.com/apache/shardingsphere/pull/38708

   
   Changes proposed in this pull request:
     - workflow: support specifying a single image for nightly E2E operation workflow
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] workflow: support specifying a single image for nightly E2E operation workflow [shardingsphere]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #38708:
URL: https://github.com/apache/shardingsphere/pull/38708#issuecomment-4497034756

     This PR improves the nightly E2E operation workflow by allowing maintainers to specify a single Docker image when triggering the workflow manually.
   
     Changes:
     - Add a `docker-image` input to `workflow_dispatch`.
     - Generate the E2E image matrix from either the specified image or the default image list.
     - Keep the scheduled workflow behavior unchanged when no image is specified.
     - Update matrix exclude rules and the Maven execution command to work with the new string-based image matrix.
   
     Verification:
     - `npx --yes github-actionlint@1.7.12 .github/workflows/nightly-e2e-operation.yml`
     - Ruby YAML parsing with `YAML.load_file`
     - `git diff --check -- .github/workflows/nightly-e2e-operation.yml`
     - Local shell validation for single-image output and image-family Maven property mapping
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] workflow: support specifying a single image for nightly E2E operation workflow [shardingsphere]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #38708:
URL: https://github.com/apache/shardingsphere/pull/38708#issuecomment-4497027658

    1. Decision block
   
     - Merge Verdict: Mergeable
     - Reviewed Scope: .github/workflows/nightly-e2e-operation.yml
     - Not Reviewed Scope: actual scheduled workflow execution on GitHub-hosted or self-hosted runners; full E2E runtime results.
     - Need Expert Review: No dedicated domain expert review is required.
   
     2. Basis
   
     - The change directly addresses the workflow usability issue by adding a workflow_dispatch input for docker-image, then generating the E2E image matrix from either the provided single image or the default image list.
     - The runtime command still maps each supported image family to the existing E2E Maven property:
         - mysql:* to e2e.docker.database.mysql.images
         - mariadb:* to e2e.docker.database.mariadb.images
         - postgres:* to e2e.docker.database.postgresql.images
         - opengauss/* to e2e.docker.database.opengauss.images
     - The default scheduled behavior is preserved because the default image list still contains the same ShardingSphere operation E2E images as before.
     - The matrix exclude rules were updated consistently after changing matrix.image from an object to a string, so the existing unsupported operation/image combinations remain excluded.
     - Design risk is low: the added prepare-e2e-matrix job is scoped to matrix preparation and does not alter artifact generation or E2E execution responsibilities.
     - Compatibility risk is low: this only changes GitHub Actions workflow orchestration and does not affect runtime code, configuration schema, API/SPI, SQL parsing, routing, or database behavior.
     - Performance and operational risk are acceptable: the new preparation job has a 5-minute timeout, and the existing E2E job still keeps max-parallel: 15.
   
     3. Pre-merge checks
   
     - npx --yes github-actionlint@1.7.12 .github/workflows/nightly-e2e-operation.yml: passed.
     - YAML parsing with Ruby YAML.load_file: passed.
     - git diff --check -- .github/workflows/nightly-e2e-operation.yml: passed.
     - Local shell validation covered:
         - single-image matrix output, for example images=["mysql:8.0"]
         - supported image-family property mapping for MySQL, MariaDB, PostgreSQL, and openGauss.
     - Recommended final confirmation before merge: run one workflow_dispatch case with a single image, for example operation=[ "pipeline" ] and docker-image=mysql:8.0, to verify the full GitHub Actions runtime path.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] workflow: support specifying a single image for nightly E2E operation workflow [shardingsphere]

Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #38708:
URL: https://github.com/apache/shardingsphere/pull/38708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org