[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #938: [#937] feat: Add rest api for servernode list of losing connection and unhealthy

["xianjingfeng (via GitHub)" <gi...@apache.org>]

xianjingfeng commented on code in PR #938:
URL: https://github.com/apache/incubator-uniffle/pull/938#discussion_r1222754491


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java:
##########
@@ -195,6 +197,12 @@ private void registerRESTAPI() throws Exception {
     jettyServer.addServlet(
         new NodesServlet(this),
         "/api/server/nodes");
+    jettyServer.addServlet(
+        new LostedNodesServlet(this),
+        "/api/server/lostedNodes");
+    jettyServer.addServlet(
+        new UnhealthyNodesServlet(this),
+        "/api/server/unhealthyNodes");

Review Comment:
   We can pass status in `NodesServlet`, so we don't need add more servlets



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org