[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6032: feat: allow TableScan without projection

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #6032:
URL: https://github.com/apache/arrow-datafusion/pull/6032#discussion_r1170060580


##########
datafusion/substrait/tests/serialize.rs:
##########
@@ -49,6 +52,20 @@ mod tests {
         Ok(())
     }
 
+    #[tokio::test]
+    async fn table_scan_without_projection() -> Result<()> {
+        let ctx = create_context().await.unwrap();
+        let table = provider_as_source(ctx.table_provider("data").await.unwrap());
+        let table_scan = LogicalPlanBuilder::scan("data", table, None)
+            .unwrap()
+            .build()
+            .unwrap();

Review Comment:
   ```suggestion
           let ctx = create_context().await?;
           let table = provider_as_source(ctx.table_provider("data").await?);
           let table_scan = LogicalPlanBuilder::scan("data", table, None)?.build()?;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org