You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/10 00:29:29 UTC
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #46: [WIP]add e2e test
hanahmily commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-swck/pull/46#discussion_r746146320
##########
File path: hack/prepare-e2e.sh
##########
@@ -0,0 +1,82 @@
+
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+OS=$(go env GOOS)
+ARCH=$(go env GOHOSTARCH)
+
+INSTALL_DIR=/usr/local/bin
+IMAGE_FILE=test/e2e/e2e.yaml
+
+prepare_ok=true
+# install kubectl
+function install_kubectl()
+{
+ if ! command -v kubectl &> /dev/null; then
+ echo "please refer https://kubernetes.io/docs/tasks/tools/#install-kubectl to install kubectl!"
+ $prepare_ok=false
+ fi
+}
+# install swctl
+function install_swctl()
+{
+ if ! command -v swctl &> /dev/null; then
+ echo "please refer https://github.com/apache/skywalking-cli to install swctl!"
Review comment:
We can install it by `go install`, and specify the version as well.
##########
File path: test/e2e/e2e.yaml
##########
@@ -0,0 +1,106 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+setup:
+ env: kind
+ file: kind.yaml
+ steps:
+ - name: install cert-manager
+ command: |
+ # kind k8s cluster is in $TMPDIR
+ cp $TMPDIR/e2e-k8s.config ~/.kube/config
+ kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.3.1/cert-manager.yaml
+ wait:
+ - namespace: cert-manager
+ resource: pod
+ for: condition=Ready
+ - name: install operator
+ command: |
+ export OPERATOR_IMG=controller:v0.4
+ make operator-docker-build
+ kind load docker-image controller:v0.4
+ make operator-install
+ make operator-deploy
+ wait:
+ - namespace: skywalking-swck-system
+ resource: pod
+ for: condition=Ready
+ - name: wait webhook installing
+ command: |
+ sleep 30
Review comment:
How about applying CR in a loop to check webhook is ready? A simple waiting will cause the test to flaky. The Github action task might be very slower than our expectation due to the cloud environment.
##########
File path: test/e2e/e2e.yaml
##########
@@ -0,0 +1,106 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+setup:
+ env: kind
+ file: kind.yaml
+ steps:
+ - name: install cert-manager
+ command: |
+ # kind k8s cluster is in $TMPDIR
+ cp $TMPDIR/e2e-k8s.config ~/.kube/config
+ kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.3.1/cert-manager.yaml
+ wait:
+ - namespace: cert-manager
+ resource: pod
+ for: condition=Ready
+ - name: install operator
+ command: |
+ export OPERATOR_IMG=controller:v0.4
+ make operator-docker-build
+ kind load docker-image controller:v0.4
+ make operator-install
+ make operator-deploy
+ wait:
+ - namespace: skywalking-swck-system
+ resource: pod
+ for: condition=Ready
+ - name: wait webhook installing
+ command: |
+ sleep 30
+ - name: setup oapserver and ui
+ command: |
+ kubectl create -f config/operator/samples/default.yaml
+ wait:
+ - namespace: default
+ resource: OAPServer/default
+ for: condition=Available
+ - namespace: default
+ resource: UI/default
+ for: condition=Available
+ - name: setup java agent demo
+ command: |
+ kubectl label namespace default swck-injection=enabled
+ sed 's/oapserver-clusterip/'$(kubectl get svc default-oap -o go-template --template='{{.spec.clusterIP}}')'/' test/e2e/demo.yaml | kubectl create -f -
Review comment:
Please deploy skywalking components to another namespace instead of `default`.
For example, `skywalking-system`. If that, pls to use`skywalking-system-oap.skywalking-system:11800` to set up the backend address of the injected agent.
##########
File path: test/e2e/e2e.yaml
##########
@@ -0,0 +1,106 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+setup:
+ env: kind
+ file: kind.yaml
+ steps:
+ - name: install cert-manager
+ command: |
+ # kind k8s cluster is in $TMPDIR
+ cp $TMPDIR/e2e-k8s.config ~/.kube/config
+ kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.3.1/cert-manager.yaml
+ wait:
+ - namespace: cert-manager
+ resource: pod
+ for: condition=Ready
+ - name: install operator
+ command: |
+ export OPERATOR_IMG=controller:v0.4
+ make operator-docker-build
+ kind load docker-image controller:v0.4
+ make operator-install
+ make operator-deploy
+ wait:
+ - namespace: skywalking-swck-system
+ resource: pod
+ for: condition=Ready
+ - name: wait webhook installing
+ command: |
+ sleep 30
+ - name: setup oapserver and ui
+ command: |
+ kubectl create -f config/operator/samples/default.yaml
+ wait:
+ - namespace: default
+ resource: OAPServer/default
+ for: condition=Available
+ - namespace: default
+ resource: UI/default
+ for: condition=Available
+ - name: setup java agent demo
+ command: |
+ kubectl label namespace default swck-injection=enabled
+ sed 's/oapserver-clusterip/'$(kubectl get svc default-oap -o go-template --template='{{.spec.clusterIP}}')'/' test/e2e/demo.yaml | kubectl create -f -
+ wait:
+ - namespace: default
+ resource: deployment/demo
+ for: condition=Available
+ kind:
+ import-images:
+ - quay.io/jetstack/cert-manager-cainjector:v1.3.1
+ - quay.io/jetstack/cert-manager-controller:v1.3.1
+ - quay.io/jetstack/cert-manager-webhook:v1.3.1
+ - docker.io/kubesphere/kube-rbac-proxy:v0.4.1
+ - docker.io/apache/skywalking-oap-server:8.8.1
+ - docker.io/apache/skywalking-ui:8.8.1
+ - ghcr.io/apache/skywalking-swck-spring-demo:v0.0.1
+ - docker.io/apache/skywalking-java-agent:8.7.0-jdk8
+ expose-ports:
+ - namespace: default
+ resource: service/demo
+ port: 8085
+ - namespace: default
+ resource: service/default-oap
+ port: 12800
+ timeout: 20m
+
+cleanup:
+ # always never success failure
+ on: always
+
+trigger:
+ action: http
+ interval: 30s
+ times: 5
+ url: http://${service_demo_host}:${service_demo_8085}/hello
+ method: GET
+
+verify:
+ # verify with retry strategy
+ retry:
+ # max retry count
+ count: 10
+ # the interval between two attempts, e.g. 10s, 1m.
+ interval: 10s
+ cases:
Review comment:
Would you pls add more cases to verify `UI` server? I don't intend to verify how the UI renders the page, but to touch the `ui_host`:`ui_port`/graphql, which would help us know whether the UI server works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org