You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/05/13 15:32:45 UTC

[GitHub] [systemds] MKehayov commented on pull request #1608: [SYSTEMDS-3371] Federated monitoring backend communication with worker nodes

MKehayov commented on PR #1608:
URL: https://github.com/apache/systemds/pull/1608#issuecomment-1126183266

   > Thanks for the patch @MKehayov. As just discussed offline, this looks already good - please double check the fasterxml dependency, tabs vs spaces, exception handling, check of existing schema, use of prepared statements, and a more compact style of assertion checking in the tests.
   
   Fasterxml was already used as dependency in /src/main/java/org/apache/sysds/runtime/io/ReaderWriterFederated. I have changed the spaces for tabs, fixed the exception handling, and schema is first checked before being created. I have rewritten the SQL statements in more generic prepared statements and fixed the one-line assertions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org