You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2016/01/05 12:16:25 UTC
Re: Review Request 41547: [2/5] Quota Authorization: Implemented
authorization of "remove quota" requests in the authorizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41547/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 12:16 p.m.)
Review request for mesos, Alexander Rukletsov and Till Toenshoff.
Changes
-------
Rebased & Addressed issues.
Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081
Repository: mesos
Description
-------
Quota Authorization: Implemented authorization of "remove quota" requests in the authorizer.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp f61613948b7b5c5c2118f1782a0c5f8ff7e8e057
src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98
src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef
src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249
src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a
Diff: https://reviews.apache.org/r/41547/diff/
Testing (updated)
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 41547: [2/5] Quota Authorization: Implemented
authorization of "remove quota" requests in the authorizer.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41547/#review112829
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 5, 2016, 11:16 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41547/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 11:16 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
>
>
> Bugs: MESOS-4081
> https://issues.apache.org/jira/browse/MESOS-4081
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota Authorization: Implemented authorization of "remove quota" requests in the authorizer.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp f61613948b7b5c5c2118f1782a0c5f8ff7e8e057
> src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98
> src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef
> src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249
> src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a
>
> Diff: https://reviews.apache.org/r/41547/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 41547: [2/5] Quota Authorization: Implemented
authorization of "remove quota" requests in the authorizer.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41547/#review112876
-----------------------------------------------------------
Ship it!
include/mesos/authorizer/authorizer.hpp (line 191)
<https://reviews.apache.org/r/41547/#comment173350>
I am not really happy with this wording as, to me, it implies that principal X != principal Y while in reality this may very well be false.
We might want to do a follow-up after landing this to fix these usings of "by another principal".
- Till Toenshoff
On Jan. 5, 2016, 11:16 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41547/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 11:16 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
>
>
> Bugs: MESOS-4081
> https://issues.apache.org/jira/browse/MESOS-4081
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota Authorization: Implemented authorization of "remove quota" requests in the authorizer.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp f61613948b7b5c5c2118f1782a0c5f8ff7e8e057
> src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98
> src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef
> src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249
> src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a
>
> Diff: https://reviews.apache.org/r/41547/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 41547: Quota: Implemented authorization of "remove
quota" requests.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41547/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 2:39 p.m.)
Review request for mesos, Alexander Rukletsov and Till Toenshoff.
Summary (updated)
-----------------
Quota: Implemented authorization of "remove quota" requests.
Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081
Repository: mesos
Description
-------
Quota Authorization: Implemented authorization of "remove quota" requests in the authorizer.
Diffs
-----
include/mesos/authorizer/authorizer.hpp f61613948b7b5c5c2118f1782a0c5f8ff7e8e057
src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98
src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef
src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249
src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a
Diff: https://reviews.apache.org/r/41547/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 41547: Quota: Implemented authorization of "remove
quota" requests in the authorizer.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41547/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 2:37 p.m.)
Review request for mesos, Alexander Rukletsov and Till Toenshoff.
Summary (updated)
-----------------
Quota: Implemented authorization of "remove quota" requests in the authorizer.
Bugs: MESOS-4081
https://issues.apache.org/jira/browse/MESOS-4081
Repository: mesos
Description
-------
Quota Authorization: Implemented authorization of "remove quota" requests in the authorizer.
Diffs
-----
include/mesos/authorizer/authorizer.hpp f61613948b7b5c5c2118f1782a0c5f8ff7e8e057
src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98
src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef
src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249
src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a
Diff: https://reviews.apache.org/r/41547/diff/
Testing
-------
make check
Thanks,
Jan Schlicht