You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2019/09/30 17:06:33 UTC
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14323
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
IMPALA-8982: Fix webserver handling of OPTIONS
Previously, Impala's webserver always returned 500 errors to OPTIONS
requests. Fixing this requires two changes:
- Squeasel is updated to 36dc66b8723980feb32196a94b46734eb5eafbf9,
which pulls in a patch that allows it to handle OPTIONS requests
correctly.
- Webserver is modified to recognize OPTIONS requests and allow
Squeasel to handle them.
Testing:
- Added a BE test that checks that OPTIONS works without SPNEGO.
- Added a test that checks that OPTIONS works when SPNEGO is turned
on. The test is currently disabled until we add curl to the
toolchain.
Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
3 files changed, 31 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/14323/1
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
IMPALA-8982: Fix webserver handling of OPTIONS
Previously, Impala's webserver always returned 500 errors to OPTIONS
requests. Fixing this requires two changes:
- Squeasel is updated to 36dc66b8723980feb32196a94b46734eb5eafbf9,
which pulls in a patch that allows it to handle OPTIONS requests
correctly.
- Webserver is modified to recognize OPTIONS requests and allow
Squeasel to handle them.
Testing:
- Added a BE test that checks that OPTIONS works without SPNEGO.
- Added a test that checks that OPTIONS works when SPNEGO is turned
on. The test is currently disabled until we add curl to the
toolchain.
Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Reviewed-on: http://gerrit.cloudera.org:8080/14323
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
3 files changed, 32 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5033/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 16:08:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4679/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 17:48:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5036/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:04:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
carrying forward
http://gerrit.cloudera.org:8080/#/c/14323/1/be/src/util/webserver-test.cc
File be/src/util/webserver-test.cc:
http://gerrit.cloudera.org:8080/#/c/14323/1/be/src/util/webserver-test.cc@351
PS1, Line 351: // TODO(todd) IMPALA-8987: import curl into native-toolchain and test this with
> Do we have a JIRA for this?
Done
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 17:22:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5031/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 02:21:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5027/
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 21:39:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5027/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 17:23:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14323
to look at the new patch set (#2).
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
IMPALA-8982: Fix webserver handling of OPTIONS
Previously, Impala's webserver always returned 500 errors to OPTIONS
requests. Fixing this requires two changes:
- Squeasel is updated to 36dc66b8723980feb32196a94b46734eb5eafbf9,
which pulls in a patch that allows it to handle OPTIONS requests
correctly.
- Webserver is modified to recognize OPTIONS requests and allow
Squeasel to handle them.
Testing:
- Added a BE test that checks that OPTIONS works without SPNEGO.
- Added a test that checks that OPTIONS works when SPNEGO is turned
on. The test is currently disabled until we add curl to the
toolchain.
Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
3 files changed, 32 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/14323/2
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14323/1/be/src/util/webserver-test.cc
File be/src/util/webserver-test.cc:
http://gerrit.cloudera.org:8080/#/c/14323/1/be/src/util/webserver-test.cc@351
PS1, Line 351: // TODO(todd): import curl into native-toolchain and test this with
Do we have a JIRA for this?
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 17:13:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4680/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 18:05:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:04:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 2:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5031/
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 06:37:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8982: Fix webserver handling of OPTIONS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14323 )
Change subject: IMPALA-8982: Fix webserver handling of OPTIONS
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4eb88c34348a7204686fae0d61a6d5546ef3a34
Gerrit-Change-Number: 14323
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 23:08:34 +0000
Gerrit-HasComments: No