You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Stephen Green (JIRA)" <ji...@apache.org> on 2010/04/30 03:20:53 UTC

[jira] Created: (LUCENE-2424) FieldDoc.toString only returns super.toString

FieldDoc.toString only returns super.toString
---------------------------------------------

                 Key: LUCENE-2424
                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
             Project: Lucene - Java
          Issue Type: Bug
          Components: Search
    Affects Versions: 3.0.1
         Environment: Mac OSX
            Reporter: Stephen Green
            Priority: Minor


The FieldDoc.toString method very carefully builds a StringBuffer sb containing the information for the FieldDoc instance and then just returns super.toString() instead of sb.toString()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: [jira] Commented: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by Stephen Green <ee...@gmail.com>.
On Fri, Apr 30, 2010 at 9:21 AM, Erick Erickson <er...@gmail.com> wrote:
> I have a note to myself to use StringBuilder rather than StringBuffer if
> it's
> single threaded. Can't look at the code now, but thought I'd mention it...
> May not matter a bit though since we probably don't spend much time here
> anyway....

Apparently not, given that I spotted this in the Lucene 2.9 branch and
it's still in the trunk :-)  At any rate, you're in the clear:  It
actually does use StringBuilder and I misspoke (misjira'd?)

I thought I was going crazy yesterday when a simple toString wasn't
working the way I expected!

Steve
-- 
Stephen Green
http://thesearchguy.wordpress.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: [jira] Commented: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by Erick Erickson <er...@gmail.com>.
I have a note to myself to use StringBuilder rather than StringBuffer if
it's
single threaded. Can't look at the code now, but thought I'd mention it...

May not matter a bit though since we probably don't spend much time here
anyway....

Erick

On Fri, Apr 30, 2010 at 5:34 AM, Michael McCandless (JIRA)
<ji...@apache.org>wrote:

>
>    [
> https://issues.apache.org/jira/browse/LUCENE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862607#action_12862607]
>
> Michael McCandless commented on LUCENE-2424:
> --------------------------------------------
>
> Woops, that's silly -- I'll commit shortly.  Thanks Stephen!
>
> > FieldDoc.toString only returns super.toString
> > ---------------------------------------------
> >
> >                 Key: LUCENE-2424
> >                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
> >             Project: Lucene - Java
> >          Issue Type: Bug
> >          Components: Search
> >    Affects Versions: 3.0.1
> >         Environment: Mac OSX
> >            Reporter: Stephen Green
> >            Assignee: Michael McCandless
> >            Priority: Minor
> >         Attachments: LUCENE-2424.patch
> >
> >
> > The FieldDoc.toString method very carefully builds a StringBuffer sb
> containing the information for the FieldDoc instance and then just returns
> super.toString() instead of sb.toString()
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

[jira] Resolved: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-2424.
----------------------------------------

    Resolution: Fixed

> FieldDoc.toString only returns super.toString
> ---------------------------------------------
>
>                 Key: LUCENE-2424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 3.0.1
>         Environment: Mac OSX
>            Reporter: Stephen Green
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9.3, 3.0.2, 3.1, 4.0
>
>         Attachments: LUCENE-2424.patch
>
>
> The FieldDoc.toString method very carefully builds a StringBuffer sb containing the information for the FieldDoc instance and then just returns super.toString() instead of sb.toString()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reassigned LUCENE-2424:
------------------------------------------

    Assignee: Michael McCandless

> FieldDoc.toString only returns super.toString
> ---------------------------------------------
>
>                 Key: LUCENE-2424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 3.0.1
>         Environment: Mac OSX
>            Reporter: Stephen Green
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-2424.patch
>
>
> The FieldDoc.toString method very carefully builds a StringBuffer sb containing the information for the FieldDoc instance and then just returns super.toString() instead of sb.toString()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by "Stephen Green (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Green updated LUCENE-2424:
----------------------------------

    Attachment: LUCENE-2424.patch

A very simple patch to fix this problem.

> FieldDoc.toString only returns super.toString
> ---------------------------------------------
>
>                 Key: LUCENE-2424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 3.0.1
>         Environment: Mac OSX
>            Reporter: Stephen Green
>            Priority: Minor
>         Attachments: LUCENE-2424.patch
>
>
> The FieldDoc.toString method very carefully builds a StringBuffer sb containing the information for the FieldDoc instance and then just returns super.toString() instead of sb.toString()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-2424.
----------------------------------------

    Fix Version/s: 3.1
       Resolution: Fixed

Thanks Stephen!

> FieldDoc.toString only returns super.toString
> ---------------------------------------------
>
>                 Key: LUCENE-2424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 3.0.1
>         Environment: Mac OSX
>            Reporter: Stephen Green
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2424.patch
>
>
> The FieldDoc.toString method very carefully builds a StringBuffer sb containing the information for the FieldDoc instance and then just returns super.toString() instead of sb.toString()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Reopened: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reopened LUCENE-2424:
----------------------------------------


backport

> FieldDoc.toString only returns super.toString
> ---------------------------------------------
>
>                 Key: LUCENE-2424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 3.0.1
>         Environment: Mac OSX
>            Reporter: Stephen Green
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9.3, 3.0.2, 3.1, 4.0
>
>         Attachments: LUCENE-2424.patch
>
>
> The FieldDoc.toString method very carefully builds a StringBuffer sb containing the information for the FieldDoc instance and then just returns super.toString() instead of sb.toString()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862607#action_12862607 ] 

Michael McCandless commented on LUCENE-2424:
--------------------------------------------

Woops, that's silly -- I'll commit shortly.  Thanks Stephen!

> FieldDoc.toString only returns super.toString
> ---------------------------------------------
>
>                 Key: LUCENE-2424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 3.0.1
>         Environment: Mac OSX
>            Reporter: Stephen Green
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-2424.patch
>
>
> The FieldDoc.toString method very carefully builds a StringBuffer sb containing the information for the FieldDoc instance and then just returns super.toString() instead of sb.toString()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2424) FieldDoc.toString only returns super.toString

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-2424:
---------------------------------------

    Fix Version/s: 2.9.3
                   3.0.2
                   3.1

> FieldDoc.toString only returns super.toString
> ---------------------------------------------
>
>                 Key: LUCENE-2424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2424
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 3.0.1
>         Environment: Mac OSX
>            Reporter: Stephen Green
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9.3, 3.0.2, 3.1, 4.0
>
>         Attachments: LUCENE-2424.patch
>
>
> The FieldDoc.toString method very carefully builds a StringBuffer sb containing the information for the FieldDoc instance and then just returns super.toString() instead of sb.toString()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org