You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ayushjariyal (via GitHub)" <gi...@apache.org> on 2025/08/20 08:34:45 UTC
[PR] Bump `ruff-pre-commit` in `.pre-commit-config.yaml` file [iceberg-python]
ayushjariyal opened a new pull request, #2362:
URL: https://github.com/apache/iceberg-python/pull/2362
issue #2341
In this PR, I update `ruff-pre-commit` (updating `v0.11.13 -> v0.12.9`) in `.pre-commit-config.yaml` file and verify it with running `make lint` command.
<img width="980" height="276" alt="Screenshot from 2025-08-20 13-57-32" src="https://github.com/user-attachments/assets/fa8d9f01-467a-4e2c-9767-f07f2603059a" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump `ruff-pre-commit` in `.pre-commit-config.yaml` file [iceberg-python]
Posted by "ayushjariyal (via GitHub)" <gi...@apache.org>.
ayushjariyal commented on PR #2362:
URL: https://github.com/apache/iceberg-python/pull/2362#issuecomment-3204839570
@Fokko, Can you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump `ruff-pre-commit` in `.pre-commit-config.yaml` file [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #2362:
URL: https://github.com/apache/iceberg-python/pull/2362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump `ruff-pre-commit` in `.pre-commit-config.yaml` file [iceberg-python]
Posted by "ayushjariyal (via GitHub)" <gi...@apache.org>.
ayushjariyal commented on PR #2362:
URL: https://github.com/apache/iceberg-python/pull/2362#issuecomment-3205336373
@Fokko , I've updated the `ruff` formatting by runnig:
```shell
poetry run ruff check . --fix
```
Please let me know if I missed anything or if further adjustments are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump `ruff-pre-commit` in `.pre-commit-config.yaml` file [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #2362:
URL: https://github.com/apache/iceberg-python/pull/2362#issuecomment-3205396496
@ayushjariyal Typically we run `make lint`, which will also include the `--fix` argument.
We don't want to touch the content under `vendor/` since that contains generated code that we don't want to alter. Could you revert these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump `ruff-pre-commit` in `.pre-commit-config.yaml` file [iceberg-python]
Posted by "ayushjariyal (via GitHub)" <gi...@apache.org>.
ayushjariyal commented on PR #2362:
URL: https://github.com/apache/iceberg-python/pull/2362#issuecomment-3205468495
@Fokko , Apologies for the earlier incorrect updates. I’ve now reverted the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Bump `ruff-pre-commit` in `.pre-commit-config.yaml` file [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #2362:
URL: https://github.com/apache/iceberg-python/pull/2362#issuecomment-3205942475
@ayushjariyal No problem at all, happens to the best of us 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org