You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2014/06/04 10:07:46 UTC
Review Request 22225: Load command does not seem to work with filter push
down
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22225/
-----------------------------------------------------------
Review request for sentry, Arun Suresh and Prasad Mujumdar.
Bugs: SENTRY-246 and SENTRY-250
https://issues.apache.org/jira/browse/SENTRY-246
https://issues.apache.org/jira/browse/SENTRY-250
Repository: sentry
Description
-------
Did a case insensitive filtering for URIs.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff656aaa754070957ad73549ca1facfa5a433952
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 524eea3725a190cce9bbb3781fa5b98fd9aa1831
Diff: https://reviews.apache.org/r/22225/diff/
Testing
-------
Tests pass.
Thanks,
Sravya Tirukkovalur
Re: Review Request 22225: Load command does not seem to work with filter
push down
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
> On June 4, 2014, 8:24 a.m., Prasad Mujumdar wrote:
> > I am not sure if I understood the issue .. The HDFS path are case sensitive. If you change it to lowercase, how do we compare the paths ?
Ah ok, I was not aware that HDFS files are case sensitive. Updating the patch.
- Sravya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22225/#review44698
-----------------------------------------------------------
On June 4, 2014, 8:07 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22225/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 8:07 a.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-246 and SENTRY-250
> https://issues.apache.org/jira/browse/SENTRY-246
> https://issues.apache.org/jira/browse/SENTRY-250
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Did a case insensitive filtering for URIs.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff656aaa754070957ad73549ca1facfa5a433952
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 524eea3725a190cce9bbb3781fa5b98fd9aa1831
>
> Diff: https://reviews.apache.org/r/22225/diff/
>
>
> Testing
> -------
>
> Tests pass.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22225: Load command does not seem to work with filter
push down
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22225/#review44698
-----------------------------------------------------------
I am not sure if I understood the issue .. The HDFS path are case sensitive. If you change it to lowercase, how do we compare the paths ?
- Prasad Mujumdar
On June 4, 2014, 8:07 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22225/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 8:07 a.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-246 and SENTRY-250
> https://issues.apache.org/jira/browse/SENTRY-246
> https://issues.apache.org/jira/browse/SENTRY-250
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Did a case insensitive filtering for URIs.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff656aaa754070957ad73549ca1facfa5a433952
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 524eea3725a190cce9bbb3781fa5b98fd9aa1831
>
> Diff: https://reviews.apache.org/r/22225/diff/
>
>
> Testing
> -------
>
> Tests pass.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22225: Load command does not seem to work with filter
push down
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22225/#review44909
-----------------------------------------------------------
Few notes:
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
<https://reviews.apache.org/r/22225/#comment79492>
Would you mind changing this to
Set<TSentryGroup> tSentryGroups = new HashSet<TSentryGroup>();
To make it JDK6 compatible?
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
<https://reviews.apache.org/r/22225/#comment79493>
This assert seems to be failing for me as the value is the priviledge set is:
server=server1->URI=file:///var/folders/dt/9zm44z9s6bjfxbrm4v36lzdc0000gp/T/1401860678102-0/data/kv1.dat->action=ALL
(the difference is capital "URI")
Jarcec
- Jarek Cecho
On June 4, 2014, 8:47 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22225/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 8:47 a.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-246 and SENTRY-250
> https://issues.apache.org/jira/browse/SENTRY-246
> https://issues.apache.org/jira/browse/SENTRY-250
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Did a case insensitive filtering for URIs.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff656aaa754070957ad73549ca1facfa5a433952
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 524eea3725a190cce9bbb3781fa5b98fd9aa1831
>
> Diff: https://reviews.apache.org/r/22225/diff/
>
>
> Testing
> -------
>
> Tests pass.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22225: Load command does not seem to work with filter
push down
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22225/#review44990
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On June 6, 2014, 11:48 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22225/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 11:48 p.m.)
>
>
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
>
>
> Bugs: SENTRY-246 and SENTRY-250
> https://issues.apache.org/jira/browse/SENTRY-246
> https://issues.apache.org/jira/browse/SENTRY-250
>
>
> Repository: sentry
>
>
> Description
> -------
>
> URIs are case sensitive, hence store URIs in backend DB with out toLowerCase().
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java a959b131b5777a0cbd0a9fc306489190c21d3bea
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 524eea3725a190cce9bbb3781fa5b98fd9aa1831
>
> Diff: https://reviews.apache.org/r/22225/diff/
>
>
> Testing
> -------
>
> Tests pass.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22225: Load command does not seem to work with filter
push down
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22225/
-----------------------------------------------------------
(Updated June 6, 2014, 11:48 p.m.)
Review request for sentry, Arun Suresh and Prasad Mujumdar.
Changes
-------
Fixed a typo.
Bugs: SENTRY-246 and SENTRY-250
https://issues.apache.org/jira/browse/SENTRY-246
https://issues.apache.org/jira/browse/SENTRY-250
Repository: sentry
Description
-------
URIs are case sensitive, hence store URIs in backend DB with out toLowerCase().
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java a959b131b5777a0cbd0a9fc306489190c21d3bea
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 524eea3725a190cce9bbb3781fa5b98fd9aa1831
Diff: https://reviews.apache.org/r/22225/diff/
Testing
-------
Tests pass.
Thanks,
Sravya Tirukkovalur
Re: Review Request 22225: Load command does not seem to work with filter
push down
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22225/
-----------------------------------------------------------
(Updated June 6, 2014, 6:52 p.m.)
Review request for sentry, Arun Suresh and Prasad Mujumdar.
Changes
-------
Addressed Jarcec's comments.
Bugs: SENTRY-246 and SENTRY-250
https://issues.apache.org/jira/browse/SENTRY-246
https://issues.apache.org/jira/browse/SENTRY-250
Repository: sentry
Description (updated)
-------
URIs are case sensitive, hence store URIs in backend DB with out toLowerCase().
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java a959b131b5777a0cbd0a9fc306489190c21d3bea
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 524eea3725a190cce9bbb3781fa5b98fd9aa1831
Diff: https://reviews.apache.org/r/22225/diff/
Testing
-------
Tests pass.
Thanks,
Sravya Tirukkovalur
Re: Review Request 22225: Load command does not seem to work with filter
push down
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22225/
-----------------------------------------------------------
(Updated June 4, 2014, 8:47 a.m.)
Review request for sentry, Arun Suresh and Prasad Mujumdar.
Changes
-------
Updated the patch to make URIs case sensitive.
Bugs: SENTRY-246 and SENTRY-250
https://issues.apache.org/jira/browse/SENTRY-246
https://issues.apache.org/jira/browse/SENTRY-250
Repository: sentry
Description
-------
Did a case insensitive filtering for URIs.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff656aaa754070957ad73549ca1facfa5a433952
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 524eea3725a190cce9bbb3781fa5b98fd9aa1831
Diff: https://reviews.apache.org/r/22225/diff/
Testing
-------
Tests pass.
Thanks,
Sravya Tirukkovalur