You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2012/09/10 23:32:14 UTC

Re: Review Request: Hive JDBC doesn't support TIMESTAMP column

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5504/#review11287
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
<https://reviews.apache.org/r/5504/#comment24230>

    Formatting: Missing space between "){"



http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
<https://reviews.apache.org/r/5504/#comment24231>

    According to the chart (taken from the back of the JDBC 4.0 spec) that I attached to HIVE-2957 getTimestamp() is also supposed to handle conversions from VARCHAR/STRING types to Timestamps. It would be cool to get that fixed here. If you don't have time can you please open a followup JIRA? Thanks.


- Carl Steinbach


On June 21, 2012, 11:09 p.m., Richard Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5504/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 11:09 p.m.)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Description
> -------
> 
> See HIVE-2957
> 
> 
> This addresses bug HIVE-2957.
>     https://issues.apache.org/jira/browse/HIVE-2957
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/data/files/datatypes.txt 1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java 1352206 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 1352206 
> 
> Diff: https://reviews.apache.org/r/5504/diff/
> 
> 
> Testing
> -------
> 
> ant test -Dtestcase=TestJdbcDriver passed.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>

Re: Review Request: Hive JDBC doesn't support TIMESTAMP column

Posted by Richard Ding <rd...@yahoo-inc.com>.

> On Sept. 10, 2012, 9:32 p.m., Carl Steinbach wrote:
> > http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java, line 474
> > <https://reviews.apache.org/r/5504/diff/1/?file=115757#file115757line474>
> >
> >     Formatting: Missing space between "){"

Fixed.


> On Sept. 10, 2012, 9:32 p.m., Carl Steinbach wrote:
> > http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java, line 477
> > <https://reviews.apache.org/r/5504/diff/1/?file=115757#file115757line477>
> >
> >     According to the chart (taken from the back of the JDBC 4.0 spec) that I attached to HIVE-2957 getTimestamp() is also supposed to handle conversions from VARCHAR/STRING types to Timestamps. It would be cool to get that fixed here. If you don't have time can you please open a followup JIRA? Thanks.

Added conversion from String to Timestamp in HiveBaseResultSet. 
Added also an implementation of setTimestamp in HivePreparedStatement.


- Richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5504/#review11287
-----------------------------------------------------------


On Sept. 11, 2012, 12:18 a.m., Richard Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5504/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 12:18 a.m.)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Description
> -------
> 
> See HIVE-2957
> 
> 
> This addresses bug HIVE-2957.
>     https://issues.apache.org/jira/browse/HIVE-2957
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/data/files/datatypes.txt 1383135 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 1383135 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java 1383135 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 1383135 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 1383135 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java 1383135 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 1383135 
> 
> Diff: https://reviews.apache.org/r/5504/diff/
> 
> 
> Testing
> -------
> 
> ant test -Dtestcase=TestJdbcDriver passed.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>