You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/15 01:12:31 UTC
[GitHub] [doris] smallhibiscus opened a new pull request, #13386: [typo](docs) fix thrift_client_timeout_ms's incorrect description
smallhibiscus opened a new pull request, #13386:
URL: https://github.com/apache/doris/pull/13386
…f en docs.
# Proposed changes
Issue Number: close #xxx
## Problem summary
Fixed thrift_client_timeout_ms's incorrect description of en docs.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataalive commented on a diff in pull request #13386: [typo](docs) fix thrift_client_timeout_ms's incorrect description
Posted by GitBox <gi...@apache.org>.
dataalive commented on code in PR #13386:
URL: https://github.com/apache/doris/pull/13386#discussion_r996232557
##########
docs/en/docs/admin-manual/config/fe-config.md:
##########
@@ -2231,4 +2231,4 @@ The latest data version currently supported, cannot be modified, and should be c
### `min_be_exec_version`
-The oldest data version currently supported, which cannot be modified, should be consistent with the `HeartbeatServer::min_be_exec_version` in the BE of the matching version.
\ No newline at end of file
+The oldest data version currently supported, which cannot be modified, should be consistent with the `HeartbeatServer::min_be_exec_version` in the BE of the matching version.
Review Comment:
这个改变了什么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] smallhibiscus commented on a diff in pull request #13386: [typo](docs) fix thrift_client_timeout_ms's incorrect description
Posted by GitBox <gi...@apache.org>.
smallhibiscus commented on code in PR #13386:
URL: https://github.com/apache/doris/pull/13386#discussion_r996245348
##########
docs/en/docs/admin-manual/config/fe-config.md:
##########
@@ -2231,4 +2231,4 @@ The latest data version currently supported, cannot be modified, and should be c
### `min_be_exec_version`
-The oldest data version currently supported, which cannot be modified, should be consistent with the `HeartbeatServer::min_be_exec_version` in the BE of the matching version.
\ No newline at end of file
+The oldest data version currently supported, which cannot be modified, should be consistent with the `HeartbeatServer::min_be_exec_version` in the BE of the matching version.
Review Comment:
这个啥都没改，显示有内容变更
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] smallhibiscus closed pull request #13386: [typo](docs) fix thrift_client_timeout_ms's incorrect description
Posted by GitBox <gi...@apache.org>.
smallhibiscus closed pull request #13386: [typo](docs) fix thrift_client_timeout_ms's incorrect description
URL: https://github.com/apache/doris/pull/13386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org