You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by GitBox <gi...@apache.org> on 2020/05/17 18:32:33 UTC

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #417: Provide unit test for partial backport PR#416 for 2.5.x

JCgH4164838Gh792C124B5 commented on pull request #417:
URL: https://github.com/apache/struts/pull/417#issuecomment-629841098


   Hello Apache Struts Team.
   
   The PR #416 was already accepted and merged, but Coveralls pointed out that code-coverage dropped.  Due to the potentially bad behaviour that could arise if Dispatcher Locale handling does not work as expected, a new set of unit tests for the Dispatcher getLocale() method has been created to confirm the expected behaviour.
   
   If this PR looks OK to everyone, then it can be cherry-picked and modified as necessary to bring the tests into the 2.6.x stream.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org