You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/09/14 08:58:56 UTC

[GitHub] spark issue #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBenchmark

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/21677
  
    Hi, @cloud-fan . 
    
    As your comment https://github.com/apache/spark/pull/22336#issuecomment-418604019, I've came to this PR.
    
    To be short, this PR changed the original `FilterPushdownBenchmark` to the current test-suite style one intentionally in order to follow `WideSchemaBenchmark` style. Now, I understand the reason why @wangyum file [SPARK-25339](https://issues.apache.org/jira/browse/SPARK-25339), but he cannot start for it.  :)
    
    Could you confirm once more to revert this change? Also, do we want to change `WideSchemaBenchmark` together to be consistent for all benchmark suite?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org