You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by XiaoYu <xi...@apache.org> on 2022/03/21 11:13:55 UTC

[type: refacotr] Remove shenyu agent module

Hi Community


after logging rocketMQ plugin merged [1]

and metrics plugin merged [2]

The shenyu agent module code will be removed[3].

The shenyu agent doc will be removed [4]


[1]: https://github.com/apache/incubator-shenyu/pull/3073
[2]: https://github.com/apache/incubator-shenyu/pull/3075
[3]: https://github.com/apache/incubator-shenyu/pull/3077
[4]: https://github.com/apache/incubator-shenyu-website/pull/500

Re: [type: refacotr] Remove shenyu agent module

Posted by hutaishi <hu...@qq.com.INVALID>.
good.&nbsp; +1



---Original---
From: "XiaoYu"<xiaoyu@apache.org&gt;
Date: Mon, Mar 21, 2022 19:13 PM
To: "dev"<dev@shenyu.apache.org&gt;;
Subject: [type: refacotr] Remove shenyu agent module


Hi Community


after logging rocketMQ plugin merged [1]

and metrics plugin merged [2]

The shenyu agent module code will be removed[3].

The shenyu agent doc will be removed [4]


[1]: https://github.com/apache/incubator-shenyu/pull/3073
[2]: https://github.com/apache/incubator-shenyu/pull/3075
[3]: https://github.com/apache/incubator-shenyu/pull/3077
[4]: https://github.com/apache/incubator-shenyu-website/pull/500

Re: [type: refacotr] Remove shenyu agent module

Posted by Kunshuai Zhu <jo...@apache.org>.
+1, LGTM

XiaoYu <xi...@apache.org> 于2022年3月21日周一 19:14写道:
>
> Hi Community
>
>
> after logging rocketMQ plugin merged [1]
>
> and metrics plugin merged [2]
>
> The shenyu agent module code will be removed[3].
>
> The shenyu agent doc will be removed [4]
>
>
> [1]: https://github.com/apache/incubator-shenyu/pull/3073
> [2]: https://github.com/apache/incubator-shenyu/pull/3075
> [3]: https://github.com/apache/incubator-shenyu/pull/3077
> [4]: https://github.com/apache/incubator-shenyu-website/pull/500

Re: [type: refacotr] Remove shenyu agent module

Posted by XiaoYu <xi...@apache.org>.
We discuss the remove the agent module in the meeting
:https://lists.apache.org/thread/ow8o0hkym6p72gsoxxk0pyk895yk4wzv

XiaoYu <xi...@apache.org> 于2022年3月21日周一 22:52写道:
>
> Hi Willem
>
> It does not affect the end user.
>
> In the previous version, there was only a simple tracing feature (we
> will tell users how to use tracing in the release log, e.g. using
> otel, skywalking plugin).
>
> The metrics and logging features are new in the current version.
>
> Thanks to the mentor for the reminder.
>
> Willem Jiang <wi...@gmail.com> 于2022年3月21日周一 21:09写道:
> >
> > Before removing these agent modules, I just want to ask a question,
> >
> > Do these changes affect the end user?
> > If so, we need to add the migration document for them besides the
> > change log in the release note.
> >
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Mon, Mar 21, 2022 at 7:14 PM XiaoYu <xi...@apache.org> wrote:
> > >
> > > Hi Community
> > >
> > >
> > > after logging rocketMQ plugin merged [1]
> > >
> > > and metrics plugin merged [2]
> > >
> > > The shenyu agent module code will be removed[3].
> > >
> > > The shenyu agent doc will be removed [4]
> > >
> > >
> > > [1]: https://github.com/apache/incubator-shenyu/pull/3073
> > > [2]: https://github.com/apache/incubator-shenyu/pull/3075
> > > [3]: https://github.com/apache/incubator-shenyu/pull/3077
> > > [4]: https://github.com/apache/incubator-shenyu-website/pull/500

Re: [type: refacotr] Remove shenyu agent module

Posted by XiaoYu <xi...@apache.org>.
Hi Willem

It does not affect the end user.

In the previous version, there was only a simple tracing feature (we
will tell users how to use tracing in the release log, e.g. using
otel, skywalking plugin).

The metrics and logging features are new in the current version.

Thanks to the mentor for the reminder.

Willem Jiang <wi...@gmail.com> 于2022年3月21日周一 21:09写道:
>
> Before removing these agent modules, I just want to ask a question,
>
> Do these changes affect the end user?
> If so, we need to add the migration document for them besides the
> change log in the release note.
>
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Mon, Mar 21, 2022 at 7:14 PM XiaoYu <xi...@apache.org> wrote:
> >
> > Hi Community
> >
> >
> > after logging rocketMQ plugin merged [1]
> >
> > and metrics plugin merged [2]
> >
> > The shenyu agent module code will be removed[3].
> >
> > The shenyu agent doc will be removed [4]
> >
> >
> > [1]: https://github.com/apache/incubator-shenyu/pull/3073
> > [2]: https://github.com/apache/incubator-shenyu/pull/3075
> > [3]: https://github.com/apache/incubator-shenyu/pull/3077
> > [4]: https://github.com/apache/incubator-shenyu-website/pull/500

Re: [type: refacotr] Remove shenyu agent module

Posted by Willem Jiang <wi...@gmail.com>.
Before removing these agent modules, I just want to ask a question,

Do these changes affect the end user?
If so, we need to add the migration document for them besides the
change log in the release note.


Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Mon, Mar 21, 2022 at 7:14 PM XiaoYu <xi...@apache.org> wrote:
>
> Hi Community
>
>
> after logging rocketMQ plugin merged [1]
>
> and metrics plugin merged [2]
>
> The shenyu agent module code will be removed[3].
>
> The shenyu agent doc will be removed [4]
>
>
> [1]: https://github.com/apache/incubator-shenyu/pull/3073
> [2]: https://github.com/apache/incubator-shenyu/pull/3075
> [3]: https://github.com/apache/incubator-shenyu/pull/3077
> [4]: https://github.com/apache/incubator-shenyu-website/pull/500

Re: [type: refacotr] Remove shenyu agent module

Posted by Zhang Yonglun <zh...@apache.org>.
LGTM

--

Zhang Yonglun
Apache ShenYu (Incubating)
Apache ShardingSphere

XiaoYu <xi...@apache.org> 于2022年3月21日周一 19:14写道:
>
> Hi Community
>
>
> after logging rocketMQ plugin merged [1]
>
> and metrics plugin merged [2]
>
> The shenyu agent module code will be removed[3].
>
> The shenyu agent doc will be removed [4]
>
>
> [1]: https://github.com/apache/incubator-shenyu/pull/3073
> [2]: https://github.com/apache/incubator-shenyu/pull/3075
> [3]: https://github.com/apache/incubator-shenyu/pull/3077
> [4]: https://github.com/apache/incubator-shenyu-website/pull/500

Re: [type: refacotr] Remove shenyu agent module

Posted by Kevin Clair <ke...@apache.org>.
LGTM

XiaoYu <xi...@apache.org> 于2022年3月21日周一 19:14写道:

> Hi Community
>
>
> after logging rocketMQ plugin merged [1]
>
> and metrics plugin merged [2]
>
> The shenyu agent module code will be removed[3].
>
> The shenyu agent doc will be removed [4]
>
>
> [1]: https://github.com/apache/incubator-shenyu/pull/3073
> [2]: https://github.com/apache/incubator-shenyu/pull/3075
> [3]: https://github.com/apache/incubator-shenyu/pull/3077
> [4]: https://github.com/apache/incubator-shenyu-website/pull/500
>

Re: [type: refacotr] Remove shenyu agent module

Posted by Liang Liu <mi...@apache.org>.
+1

On 2022/03/21 11:13:55 XiaoYu wrote:
> Hi Community
> 
> 
> after logging rocketMQ plugin merged [1]
> 
> and metrics plugin merged [2]
> 
> The shenyu agent module code will be removed[3].
> 
> The shenyu agent doc will be removed [4]
> 
> 
> [1]: https://github.com/apache/incubator-shenyu/pull/3073
> [2]: https://github.com/apache/incubator-shenyu/pull/3075
> [3]: https://github.com/apache/incubator-shenyu/pull/3077
> [4]: https://github.com/apache/incubator-shenyu-website/pull/500
>