You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/05 21:55:06 UTC
[GitHub] [hive] viirya opened a new pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
viirya opened a new pull request #1365:
URL: https://github.com/apache/hive/pull/1365
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-672565238
@viirya Yes please do. Sorry about that :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-672564334
Oh ok. I need to create a new PR for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669633435
This was successfully built. How do I trigger the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-672564659
No there is already a PR to revert it (see above message). I'll get it merged soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669587774
I think so. You can sign-in with your github account and see if the option is there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-672565439
No problem at all. @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669665180
@viirya added test pending - let's see
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669585994
Sure @viirya - restarted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669710036
@sunchao looks like it doesn't trigger testing.
@kgyrtkirk Hi, do you know how to trigger the tests? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-672564936
Oh, I mean a new PR for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669959284
@viirya It may be because the PR action only support master and branch-2 right now, not branch-2.3. I suggest you submit a patch to the JIRA ticket similar to https://issues.apache.org/jira/browse/HIVE-22249.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya edited a comment on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669574011
cc @sunchao I saw the <del>test</del> build was timeout, can we re-trigger the <del>test</del> build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-672564132
Oops. Sorry I merged this by mistake. Will create a PR to revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-672565803
@viirya reverted - please ping me on the new PR and let's see if we can figure this testing thing out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669658564
Seems a label "tests pending" is needed for triggering testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-670017177
@sunchao Ok, I see. I will do. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669574011
cc @sunchao I saw the test was timeout, can we re-trigger the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-670807908
It seems the patch approach also doesn't work. ping @pvary @kgyrtkirk : do you know a way to trigger tests? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #1365:
URL: https://github.com/apache/hive/pull/1365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1365: HIVE-23998: Upgrade guava to 27 for Hive 2.3 branch
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1365:
URL: https://github.com/apache/hive/pull/1365#issuecomment-669586669
Thanks, is it only re-triggerable by Hive committers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org