[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4555: Cleanup a bunch of raw type error msgs related to TreeSet.

[GitBox <gi...@apache.org>]

matthiasblaesing commented on code in PR #4555:
URL: https://github.com/apache/netbeans/pull/4555#discussion_r957110059


##########
platform/openide.filesystems/src/org/openide/filesystems/DefaultAttributes.java:
##########
@@ -1036,7 +1036,7 @@ protected String[] getAllowedAttrs() {
          */
         public void writeToXML(PrintWriter pw) /*throws IOException */ {
             // list of names
-            Iterator<String> it = new TreeSet(keySet()).iterator();
+            Iterator<String> it = new TreeSet<String>(keySet()).iterator();

Review Comment:
   Why not diamond?



##########
enterprise/web.jspparser/src/org/netbeans/modules/web/jsps/parserapi/PageInfo.java:
##########
@@ -635,7 +635,7 @@ public boolean isELIgnored() {
     
     // added in NetBeans
     
-    public Map getTagLibraries() {
+    public Map<String, TagLibraryInfo> getTagLibraries() {

Review Comment:
   Changing public API (adding generics) - but looks sane to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists