You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Aaron T. Myers (JIRA)" <ji...@apache.org> on 2011/05/26 01:26:47 UTC
[jira] [Created] (HDFS-1999) Tests use deprecated configs
Tests use deprecated configs
----------------------------
Key: HDFS-1999
URL: https://issues.apache.org/jira/browse/HDFS-1999
Project: Hadoop HDFS
Issue Type: Bug
Components: test
Affects Versions: 0.22.0, 0.23.0
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
Fix For: 0.22.0, 0.23.0
A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039633#comment-13039633 ]
Hadoop QA commented on HDFS-1999:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480512/hdfs-1999.0.patch
against trunk revision 1127759.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 47 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileAppend4
org.apache.hadoop.hdfs.TestLargeBlock
org.apache.hadoop.hdfs.TestWriteConfigurationToDFS
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//console
This message is automatically generated.
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039522#comment-13039522 ]
Eli Collins commented on HDFS-1999:
-----------------------------------
The tests should use DFSConfigKeys, otherwise looks great.
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039745#comment-13039745 ]
Hudson commented on HDFS-1999:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #688 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/688/])
Amend HDFS-1999: missing import in system tests
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127966
Files :
* /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039674#comment-13039674 ]
Hudson commented on HDFS-1999:
------------------------------
Integrated in Hadoop-Hdfs-trunk #678 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/678/])
HDFS-1999. Tests use deprecated configs. Contributed by Aaron T. Myers
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127823
Files :
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSafeMode.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/hadoop-dfs-dir.txt
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/UpgradeUtilities.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/CreateEditsLog.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestSafeMode.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/MiniDFSCluster.java
* /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSStorageStateRecovery.java
* /hadoop/hdfs/trunk/CHANGES.txt
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040211#comment-13040211 ]
Hudson commented on HDFS-1999:
------------------------------
Integrated in Hadoop-Hdfs-trunk #679 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/679/])
Amend HDFS-1999: missing import in system tests
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127966
Files :
* /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1999) Tests use deprecated configs
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-1999:
---------------------------------
Fix Version/s: (was: 0.22.0)
Status: Patch Available (was: Open)
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039579#comment-13039579 ]
Eli Collins commented on HDFS-1999:
-----------------------------------
The TestQuota timeout is unrelated.
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039740#comment-13039740 ]
Todd Lipcon commented on HDFS-1999:
-----------------------------------
Looks like this commit broke the system test compilation. I'm not sure why Hudson QA gave it a +1. I will fix this in-place since it's just a missing import.
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1999) Tests use deprecated configs
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-1999:
---------------------------------
Attachment: hdfs-1999.0.patch
Patch for trunk which replaces all references to deprecated config keys (including comments) in {{src/test/*}} with the corresponding superseding keys.
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1999) Tests use deprecated configs
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1999:
------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've committed this. Thanks atm!
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1999) Tests use deprecated configs
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-1999:
---------------------------------
Attachment: hdfs-1999.1.patch
Thanks a lot for the review, Eli. Attached is a patch addressing your comments.
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039533#comment-13039533 ]
Eli Collins commented on HDFS-1999:
-----------------------------------
+1 pending Hudson
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039753#comment-13039753 ]
Tsz Wo (Nicholas), SZE commented on HDFS-1999:
----------------------------------------------
> ... I'm not sure why Hudson QA gave it a +1. ...
System test seems not working for a long time.
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1999) Tests use deprecated configs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039571#comment-13039571 ]
Hadoop QA commented on HDFS-1999:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480512/hdfs-1999.0.patch
against trunk revision 1127759.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 47 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestQuota
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//console
This message is automatically generated.
> Tests use deprecated configs
> ----------------------------
>
> Key: HDFS-1999
> URL: https://issues.apache.org/jira/browse/HDFS-1999
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1999.0.patch, hdfs-1999.1.patch
>
>
> A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira