You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/06 21:28:19 UTC
[GitHub] [beam] angoenka opened a new pull request #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
angoenka opened a new pull request #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326
…ests
The changes are only temporary till we have 2.21 out. The changes should be reverted before 2.21 is cut.
R: @ananvay @robertwb @lukecwik
cc: @ibzib
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka merged pull request #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka merged pull request #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610575380
Run Python Dataflow V2 ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ananvay commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
ananvay commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610048588
Thanks Ankur! LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610654341
Had offline discussion with Robert and going ahead with the merge. We will need to sickbay the test or publish a new UW image with the fix which can be done separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ananvay commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
ananvay commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610654070
Can we loop in Luke and/or sickbay the test to get this PR in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610576307
Run Python Dataflow V2 ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610570866
I can add the code to check if the version has dev in it to ensure that its not used in release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610046724
Run Python Dataflow V2 ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610074231
Run Python Dataflow V2 ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610575567
updated the PR to only set the image when version is dev.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610653192
The failing metric test seems to be working on my local repo https://gradle.com/s/snptwrrxau5we
The issue might be the recent changes to beam metric proto cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11326: [BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t…
URL: https://github.com/apache/beam/pull/11326#issuecomment-610571787
> I can add the code to check if the version has dev in it to ensure that its not used in release.
That makes more sense to me, especially if you were planning on undoing the revert after the cut (?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services