[GitHub] [airflow] uranusjr commented on a diff in pull request #25675: Adding a parameter for exclusion of trashed files in GoogleDriveHook

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #25675:
URL: https://github.com/apache/airflow/pull/25675#discussion_r944095967


##########
airflow/providers/google/suite/hooks/drive.py:
##########
@@ -128,31 +128,45 @@ def get_media_request(self, file_id: str) -> HttpRequest:
         request = service.files().get_media(fileId=file_id)
         return request
 
-    def exists(self, folder_id: str, file_name: str, drive_id: Optional[str] = None):
+    def exists(
+        self, folder_id: str, file_name: str, include_trashed: bool = True, drive_id: Optional[str] = None

Review Comment:
   Can we change the ordering to put `include_trashed` at the back? Right now this (unnecessarily) breaks backward compatibility if the user passes `drive_id` as a positional argument.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org