You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/18 19:41:11 UTC

[GitHub] [airflow] dimberman opened a new pull request #8904: Move k8s files out of contrib

dimberman opened a new pull request #8904:
URL: https://github.com/apache/airflow/pull/8904


   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Target Github ISSUE in description if exists
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427481728



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       Yes. This was because of flake8 errors.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630751274


   Yep. It's very likely. I think we fixed similar problems in one of the commits in master. Looking at the requirements.txt Flake8 3.8.0 (and then 3.8.1 right after) has been released 12th of May. You simply need to fix those @dimberman 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r426895969



##########
File path: .github/workflows/ci.yml
##########
@@ -123,7 +123,7 @@ jobs:
         run: ./scripts/ci/ci_free_space_on_ci.sh
       - name: "Build CI image ${{ matrix.python-version }}"
         run: ./scripts/ci/ci_prepare_image_on_ci.sh
-      - name: "Tests"
+      - ame: "Tests"

Review comment:
       and it's only Monday lol




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427490782



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       also if you're running .format on the string before it's even parsed does it even matter?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427490378



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       @kaxil any thoughts on what to do here? change them or set ignore flags?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630734168


   > @potiuk do you have any idea why all of these unrelated flake tests would fail?
   > 
   > ```
   > 
   > tests/contrib/utils/base_gcp_system_test_case.py:89:0: F523 '...'.format(...) has unused arguments at position(s): 0
   > airflow/jobs/backfill_job.py:559:33: F523 '...'.format(...) has unused arguments at position(s): 0, 1
   > airflow/contrib/utils/gcp_field_validator.py:253:17: F523 '...'.format(...) has unused arguments at position(s): 1
   > airflow/operators/docker_operator.py:268:17: E741 ambiguous variable name 'l'
   > tests/contrib/operators/test_gcs_to_gcs_operator.py:290:21: F523 '...'.format(...) has unused arguments at position(s): 1
   > airflow/contrib/operators/file_to_wasb.py:60:13: F523 '...'.format(...) has unused arguments at position(s): 0, 1, 2
   > airflow/contrib/operators/qubole_check_operator.py:226:17: E122 continuation line missing indentation or outdented
   > ```
   
   That is most likely caused by the new version release of flake8 on May 12 that may have introduced extra checks !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil edited a comment on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630734168


   > @potiuk do you have any idea why all of these unrelated flake tests would fail?
   > 
   > ```
   > 
   > tests/contrib/utils/base_gcp_system_test_case.py:89:0: F523 '...'.format(...) has unused arguments at position(s): 0
   > airflow/jobs/backfill_job.py:559:33: F523 '...'.format(...) has unused arguments at position(s): 0, 1
   > airflow/contrib/utils/gcp_field_validator.py:253:17: F523 '...'.format(...) has unused arguments at position(s): 1
   > airflow/operators/docker_operator.py:268:17: E741 ambiguous variable name 'l'
   > tests/contrib/operators/test_gcs_to_gcs_operator.py:290:21: F523 '...'.format(...) has unused arguments at position(s): 1
   > airflow/contrib/operators/file_to_wasb.py:60:13: F523 '...'.format(...) has unused arguments at position(s): 0, 1, 2
   > airflow/contrib/operators/qubole_check_operator.py:226:17: E122 continuation line missing indentation or outdented
   > ```
   
   That is most likely caused by the new version release of flake8 on May 12 that may have introduced extra checks ! - https://pypi.org/project/flake8/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r426896828



##########
File path: .github/workflows/ci.yml
##########
@@ -123,7 +123,7 @@ jobs:
         run: ./scripts/ci/ci_free_space_on_ci.sh
       - name: "Build CI image ${{ matrix.python-version }}"
         run: ./scripts/ci/ci_prepare_image_on_ci.sh
-      - name: "Tests"
+      - ame: "Tests"

Review comment:
       Na it's like..... oh fu..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427466843



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       Was this changes because of a flake8 error ? We use `%s` format for logs so that the arguments are passed properly when logging levels are changed 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630806970


   Thanks @potiuk @kaxil just wanted to make sure I wasn't making the problem worse :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r428127373



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading %s to wasb://%s '  # noqa: F523
+            'as %s'.format(self.file_path, self.container_name, self.blob_name)  # noqa: F523
         )

Review comment:
       ```suggestion
               'as %s', self.file_path, self.container_name, self.blob_name)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427586701



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       The fix here is to do
   
   ```python
           self.log.info(
               'Uploading %s to wasb://%s as %s',
               self.file_path, self.container_name, self.blob_name)
   ```
   
   That way if the logging level is disabled, no time is wasted formatting the string




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427555106



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       @kaxil fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427588906



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       @ashb If possible I'd like to avoid making changes unrelated to the commit on this PR (especially since it's going straight to 1-10). Should we make a separate PR for fixing these logs?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630396516


   Many k8soperator/k8sexecutor PRs need to be essentially recreated from scratch because git can no longer merge. I'm hoping to make a few PRs like this to bring 1-10 and master closer together


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630438161


   @ashb some point tomorrow I might need some help on this PR. I'm getting a bunch of flake8 failures that seem completely unrelated to any code changes I made so not sure if something is funky with 1-10-test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630751274


   Yep. It's very likely. I think we fixed those problems in one of the commits. Looking at the requirements.txt Flake8 3.8.0 (and then 3.8.1 right after) has been released 12th of May. You simply need to fix those @dimberman 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427545856



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       Coz of https://github.com/apache/airflow/pull/4804#issuecomment-468594870




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #8904: Move Kubernetes modules out of contrib to match 2.0 layout

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-632373196


   @dimberman Needs rebasing now please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427648246



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       Oh gotcha. I mean you are already changing this, so it's going to conflict anyway.
   
   Potato potato.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r426895275



##########
File path: .github/workflows/ci.yml
##########
@@ -123,7 +123,7 @@ jobs:
         run: ./scripts/ci/ci_free_space_on_ci.sh
       - name: "Build CI image ${{ matrix.python-version }}"
         run: ./scripts/ci/ci_prepare_image_on_ci.sh
-      - name: "Tests"
+      - ame: "Tests"

Review comment:
       Whopsie :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427588906



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       @ashb If possible I'd like to avoid making changes unrelated to the commit on this PR (especially since it's going straight to 1-10). Should we make a separate PR for fixing these logs/flake8 tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman commented on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630442531


   @potiuk do you have any idea why all of these unrelated flake tests would fail?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman merged pull request #8904: Move Kubernetes modules out of contrib to match 2.0 layout

Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #8904:
URL: https://github.com/apache/airflow/pull/8904


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dimberman edited a comment on pull request #8904: Move k8s files out of contrib

Posted by GitBox <gi...@apache.org>.
dimberman edited a comment on pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#issuecomment-630442531


   @potiuk do you have any idea why all of these unrelated flake tests would fail?
   
   ```
   
   tests/contrib/utils/base_gcp_system_test_case.py:89:0: F523 '...'.format(...) has unused arguments at position(s): 0
   airflow/jobs/backfill_job.py:559:33: F523 '...'.format(...) has unused arguments at position(s): 0, 1
   airflow/contrib/utils/gcp_field_validator.py:253:17: F523 '...'.format(...) has unused arguments at position(s): 1
   airflow/operators/docker_operator.py:268:17: E741 ambiguous variable name 'l'
   tests/contrib/operators/test_gcs_to_gcs_operator.py:290:21: F523 '...'.format(...) has unused arguments at position(s): 1
   airflow/contrib/operators/file_to_wasb.py:60:13: F523 '...'.format(...) has unused arguments at position(s): 0, 1, 2
   airflow/contrib/operators/qubole_check_operator.py:226:17: E122 continuation line missing indentation or outdented
   
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org