You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Matteo Bertozzi (JIRA)" <ji...@apache.org> on 2013/01/17 01:16:14 UTC

[jira] [Created] (HBASE-7596) Redundant FSTableDescriptor update

Matteo Bertozzi created HBASE-7596:
--------------------------------------

             Summary: Redundant FSTableDescriptor update
                 Key: HBASE-7596
                 URL: https://issues.apache.org/jira/browse/HBASE-7596
             Project: HBase
          Issue Type: Bug
          Components: master
    Affects Versions: 0.94.4, 0.96.0
            Reporter: Matteo Bertozzi
            Assignee: Matteo Bertozzi
            Priority: Trivial


The TableAddFamilyHandler and TableDeleteFamilyHandler code looks like
{code}
// Update table descriptor in HDFS
HTableDescriptor htd = this.masterServices.getMasterFileSystem()
    .addColumn(tableName, familyDesc);
// Update in-memory descriptor cache
this.masterServices.getTableDescriptors().add(htd);
{code}

while the ModifyTableHandler code is just
{code}
// Update descriptor
this.masterServices.getTableDescriptors().add(this.htd);
{code}

The MasterFileSystem code looks like
{code}
HTableDescriptor htd = this.services.getTableDescriptors().get(tableName);
// ...add/remove columns to the descriptor...
this.services.getTableDescriptors().add(htd);
{code}

so, the service.getTableDescriptors().add() is called two times for the add/delete family handler. (and the table descriptor rewritten twice FSTableDescriptors.updateHTableDescriptor())

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira