You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 16:00:49 UTC

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #415: use prettier to auto format md files

alamb commented on a change in pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415#discussion_r638936568



##########
File path: .github/workflows/dev.yml
##########
@@ -23,7 +23,22 @@ on:
   pull_request:
 
 jobs:
+  prettier:
+    runs-on: ubuntu-latest
 
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          # Make sure the actual branch is checked out when running on pull requests
+          ref: ${{ github.head_ref }}
+
+      - name: Prettify code
+        uses: creyD/prettier_action@v3.3

Review comment:
       I think apache repos are limited to official github actions or ones that are local to this repo (there were some security issues previously):.
   
   > Notice: December 27, 2020: We only allow Actions that are official "Made by GitHub" or local to the Apache org on GitHub, to address a potential security vulnerability. This is an incident-related policy change. We are researching the situation, and the policy may evolve based on what we learn.
   
   https://infra.apache.org/github-actions-secrets.html
   
   
   Given https://github.com/creyD/prettier_action appears to be MIT licensed, however, what about copying the code for that action into this repo?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org