[jira] [Comment Edited] (CAMEL-19392) Correct template bean definition schema

["Tomohisa Igarashi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-19392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726569#comment-17726569 ] 

Tomohisa Igarashi edited comment on CAMEL-19392 at 5/26/23 10:04 AM:
---------------------------------------------------------------------

Yes, on main branch, this was fixed as a part of https://issues.apache.org/jira/browse/CAMEL-19386


was (Author: igarashitm):
Yes, this was fixed as a part of https://issues.apache.org/jira/browse/CAMEL-19386

> Correct template bean definition schema
> ---------------------------------------
>
>                 Key: CAMEL-19392
>                 URL: https://issues.apache.org/jira/browse/CAMEL-19392
>             Project: Camel
>          Issue Type: Task
>          Components: camel-yaml-dsl
>    Affects Versions: 3.x
>            Reporter: Tomohisa Igarashi
>            Assignee: Tomohisa Igarashi
>            Priority: Minor
>             Fix For: 3.21.0
>
>
> The template bean, which is used by Kamelet, is out of sync between schema and actually used deserializer/definition
> https://github.com/apache/camel/blob/camel-3.x/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/main/java/org/apache/camel/dsl/yaml/deserializers/RouteTemplateDefinitionDeserializer.java#L48
> https://github.com/apache/camel/blob/camel-3.x/dsl/camel-yaml-dsl/camel-yaml-dsl-deserializers/src/main/java/org/apache/camel/dsl/yaml/deserializers/RouteTemplateDefinitionDeserializer.java#L88
> NamedBeanDefinition supports
> {noformat}
> properties:
>   propName: propValue
>   objProp:
>     objPropProp: objPropPropVal
> {noformat}
> But the template bean actually supports following
> {noformat}
> property:
>   - key: propName
>     value: propValue
> {noformat}
> and
> {noformat}
> properties:
>   propName: propValue
> {noformat}
> In order to reflect the actual behavior in YAML DSL JSON schema, we need to change from `NamedBeanDefinition` to `RouteTemplateBeanDefinition` and `TemplatedRouteBeanDefinition` in the annotation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)