You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2021/05/19 01:10:30 UTC

[skywalking] branch master updated: Fix: `!=` is not supported in oal when parameters are numbers (#6968)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new e7d6b54  Fix: `!=` is not supported in oal when parameters are numbers (#6968)
e7d6b54 is described below

commit e7d6b5457bcbdac370a4a7912766510253ec7f4b
Author: liqiangz <li...@gmail.com>
AuthorDate: Wed May 19 09:10:04 2021 +0800

    Fix: `!=` is not supported in oal when parameters are numbers (#6968)
---
 CHANGES.md                                                           | 1 +
 .../oap/server/core/analysis/metrics/expression/NotEqualMatch.java   | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/CHANGES.md b/CHANGES.md
index 4168f07..a8a232d 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -43,6 +43,7 @@ Release Notes.
 * Allow multiple definitions as fallback in metadata-service-mapping.yaml file.
 * Fix: NPE when configmap has no data.
 * Fix: Dynamic Configuration key `slowTraceSegmentThreshold` not work
+* Fix: `!=` is not supported in oal when parameters are numbers.
 
 #### UI
 * Add logo for kong plugin.
diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/NotEqualMatch.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/NotEqualMatch.java
index 6475bc5..5e9bfa1 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/NotEqualMatch.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/NotEqualMatch.java
@@ -23,6 +23,11 @@ import org.apache.skywalking.oap.server.core.analysis.metrics.annotation.FilterM
 
 @FilterMatcher
 public class NotEqualMatch {
+
+    public boolean match(int left, int right) {
+        return left != right;
+    }
+
     public boolean match(Object left, Object right) {
         return !Objects.equals(left, right);
     }