You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by id...@apache.org on 2007/05/30 20:57:47 UTC
svn commit: r542910 - in /myfaces/tobago/trunk/core/src:
main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java
test/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterUnitTest.java
Author: idus
Date: Wed May 30 11:57:46 2007
New Revision: 542910
URL: http://svn.apache.org/viewvc?view=rev&rev=542910
Log:
fixed wrong invocation of toString on an array; thanks to FindBugs
Modified:
myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java
myfaces/tobago/trunk/core/src/test/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterUnitTest.java
Modified: myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java?view=diff&rev=542910&r1=542909&r2=542910
==============================================================================
--- myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java (original)
+++ myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java Wed May 30 11:57:46 2007
@@ -188,7 +188,7 @@
throws IOException {
closeOpenTag();
if (xml) {
- writer.write(XmlUtils.escape(text.toString()).toCharArray(), offset, length);
+ writer.write(XmlUtils.escape(String.valueOf(text)).toCharArray(), offset, length);
// FIXME: not nice: XmlUtils.escape(text.toString()).toCharArray()
} else {
helper.writeText(text, offset, length);
Modified: myfaces/tobago/trunk/core/src/test/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterUnitTest.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/test/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterUnitTest.java?view=diff&rev=542910&r1=542909&r2=542910
==============================================================================
--- myfaces/tobago/trunk/core/src/test/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterUnitTest.java (original)
+++ myfaces/tobago/trunk/core/src/test/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterUnitTest.java Wed May 30 11:57:46 2007
@@ -104,4 +104,10 @@
writer1.close();
assertEquals("<input value=\"Gutschein über 100 €.\" readonly=\"readonly\"\n>", stringWriter.toString());
}
+
+ public void testCharArray() throws IOException {
+ TobagoResponseWriterImpl writer = new TobagoResponseWriterImpl(stringWriter, "text/xml", "ISO-8859-1");
+ writer.writeText("123".toCharArray(), 0, 3);
+ assertEquals("123", stringWriter.toString());
+ }
}