You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/07 14:23:18 UTC

[GitHub] [cloudstack] DaanHoogland opened a new pull request #5082: component test ports/fixes in python3

DaanHoogland opened a new pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082


   ### Description
   
   This PR fixes marvin component tests to run in ported marvin framework for python3
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   part of #3195
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [x] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909411732


   @blueorangutan test matrix keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-904573893


   @DaanHoogland thanks, good work!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-865753216


   test_egress_fw_rules.py in a new env shows the new failure succeeding, skipping this test (for now):
   
   ```
   Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS ===
   ok
   ```
   the difference in time in the first comparison is now an exception in py2 and still a failure in py3:
   ```
   Test egress rule with /32 CIDR of a VM, and check other VM in the ... === TestName: test_01_2_egress_fr1 | Status : EXCEPTION ===
   ERROR
   ```
   vs
   ```
   Test egress rule with /32 CIDR of a VM, and check other VM in the ... === TestName: test_01_2_egress_fr1 | Status : FAILED ===
   FAIL
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909230377






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-888414567


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-888383549


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909258587


   <b>Trillian Build Failed (tid-1865)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-870323917


   Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-892593659


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 752


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909230377






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909232490


   <b>Trillian Build Failed (tid-1860)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909229913






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-855979801


   initial test results:
   ```
   Test completed. 104 look ok, 68 have errors
   ```
   
   however
   ```
   # ls tests/component/ | wc
       159     159    4106
   ```
   still to investigate the discrepency between 104+68 and 159 ???
   
   cc @borisstoyanov @rhtyd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909411732


   @blueorangutan test matrix keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-872120781


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-882427201






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-882427201






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-855979801


   ```
   Test completed. 104 look ok, 68 have errors
   ```
   
   however
   ```
   # ls tests/component/ | wc
       159     159    4106
   ```
   still to investigate the discrepency between 104+68 and 159 ???
   
   cc @borisstoyanov @rhtyd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-869542968


   multiple ips per nic:
   
   python2:
   ```
   Add secondary IP to NIC of a VM ... === TestName: test_add_ip_to_nic_1_SHARED | Status : SUCCESS ===
   ok
   Test listing nics associated with the ip address ... === TestName: test_list_nics_1_ISOLATED | Status : SUCCESS ===
   ok
   Test listing nics associated with the ip address ... === TestName: test_list_nics_2_SHARED | Status : SUCCESS ===
   ok
   Test listing nics associated with the ip address ... === TestName: test_list_nics_3_VPC | Status : SUCCESS ===
   ok
   Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_1_ISOLATED | Status : SUCCESS ===
   ok
   Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_2_SHARED | Status : SUCCESS ===
   ok
   Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_3_VPC | Status : SUCCESS ===
   ok
   Remove invalid ip ... === TestName: test_remove_invalid_ip | Status : SUCCESS ===
   ok
   Remove secondary IP from NIC of a VM ... === TestName: test_remove_ip_from_nic_1_ISOLATED | Status : SUCCESS ===
   ok
   Remove secondary IP from NIC of a VM ... === TestName: test_remove_ip_from_nic_2_SHARED | Status : SUCCESS ===
   ok
   Remove secondary IP from NIC of a VM ... === TestName: test_remove_ip_from_nic_3_VPC | Status : EXCEPTION ===
   ERROR
   === TestName: test_remove_ip_from_nic_3_VPC | Status : EXCEPTION ===
   ERROR
   === TestName: test_remove_ip_from_nic_3_VPC | Status : EXCEPTION ===
   ERROR
   === TestName: test_remove_ip_from_nic_3_VPC | Status : EXCEPTION ===
   ERROR
   ```
   
   and py3 
   ```
   Add secondary IP to NIC of a VM ... === TestName: test_add_ip_to_nic_1_SHARED | Status : SUCCESS ===
   ok
   Test listing nics associated with the ip address ... === TestName: test_list_nics_1_ISOLATED | Status : SUCCESS ===
   ok
   Test listing nics associated with the ip address ... === TestName: test_list_nics_2_SHARED | Status : SUCCESS ===
   ok
   Test listing nics associated with the ip address ... === TestName: test_list_nics_3_VPC | Status : SUCCESS ===
   ok
   Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_1_ISOLATED | Status : SUCCESS ===
   ok
   Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_2_SHARED | Status : SUCCESS ===
   ok
   Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_3_VPC | Status : SUCCESS ===
   ok
   Remove invalid ip ... === TestName: test_remove_invalid_ip | Status : SUCCESS ===
   ok
   Remove secondary IP from NIC of a VM ... === TestName: test_remove_ip_from_nic_1_ISOLATED | Status : SUCCESS ===
   ok
   Remove secondary IP from NIC of a VM ... === TestName: test_remove_ip_from_nic_2_SHARED | Status : SUCCESS ===
   ok
   Remove secondary IP from NIC of a VM ... === TestName: test_remove_ip_from_nic_3_VPC | Status : SUCCESS ===
   ok
   Add secondary IP to NIC of a VM ... === TestName: test_add_PF_rule_1_ISOLATED | Status : FAILED ===
   FAIL
   Add secondary IP to NIC of a VM ... === TestName: test_add_PF_rule_2_SHARED | Status : FAILED ===
   FAIL
   Add secondary IP to NIC of a VM ... === TestName: test_add_PF_rule_3_VPC | Status : FAILED ===
   FAIL
   Add secondary IP to NIC of a VM ... === TestName: test_add_static_nat_rule_1_ISOLATED | Status : FAILED ===
   FAIL
   === TestName: test_add_static_nat_rule_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_add_static_nat_rule_2_SHARED | Status : EXCEPTION ===
   ERROR
   === TestName: test_add_static_nat_rule_2_SHARED | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_add_static_nat_rule_3_VPC | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : EXCEPTION ===
   Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_2_SHARED | Status : EXCEPTION ===
   ERROR
   === TestName: test_delete_PF_nat_rule_2_SHARED | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_3_VPC | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   === TestName: test_disable_static_nat_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_2_SHARED | Status : EXCEPTION ===
   ERROR
   === TestName: test_disable_static_nat_2_SHARED | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_3_VPC | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status : EXCEPTION ===
   ERROR
   === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status : EXCEPTION ===
   ERROR
   Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status : EXCEPTION ===
   ERROR
   === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status : EXCEPTION ===
   ERROR
   Test delete VM and verify network rules are cleaned up ... === TestName: test_delete_vm_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   === TestName: test_delete_vm_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   Test delete VM and verify network rules are cleaned up ... === TestName: test_delete_vm_2_SHARED | Status : EXCEPTION ===
   ERROR
   Test delete VM and verify network rules are cleaned up ... === TestName: test_delete_vm_3_VPC | Status : EXCEPTION ===
   ERROR
   Test network restart (cleanup True) with VM having secondary IPs and related network rules ... === TestName: test_network_restart_cleanup_false_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   === TestName: test_network_restart_cleanup_false_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   Test network restart (cleanup True) with VM having secondary IPs and related network rules ... === TestName: test_network_restart_cleanup_false_2_SHARED | Status : EXCEPTION ===
   ERROR
   Test network restart (cleanup True) with VM having secondary IPs and related network rules ... === TestName: test_network_restart_cleanup_false_3_VPC | Status : EXCEPTION ===
   ERROR
   Test network restart (cleanup True) with VM having secondary IPs and related network rules ... === TestName: test_network_restart_cleanup_true_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   === TestName: test_network_restart_cleanup_true_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   Test network restart (cleanup True) with VM having secondary IPs and related network rules ... === TestName: test_network_restart_cleanup_true_2_SHARED | Status : EXCEPTION ===
   ERROR
   Test network restart (cleanup True) with VM having secondary IPs and related network rules ... === TestName: test_network_restart_cleanup_true_3_VPC | Status : EXCEPTION ===
   ERROR
   Test reboot router and persistence of network rules ... === TestName: test_reboot_router_VM_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   === TestName: test_reboot_router_VM_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   Test reboot router and persistence of network rules ... === TestName: test_reboot_router_VM_2_SHARED | Status : EXCEPTION ===
   ERROR
   Test reboot router and persistence of network rules ... === TestName: test_reboot_router_VM_3_VPC | Status : EXCEPTION ===
   ERROR
   Test recover VM operation with VM having secondary IPs ... === TestName: test_recover_vm_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   === TestName: test_recover_vm_1_ISOLATED | Status : EXCEPTION ===
   ERROR
   Test recover VM operation with VM having secondary IPs ... === TestName: test_recover_vm_2_SHARED | Status : EXCEPTION ===
   ERROR
   Test recover VM operation with VM having secondary IPs ... === TestName: test_recover_vm_3_VPC | Status : EXCEPTION ===
   ERROR
   
   ```
   
   So in conclusion more successes in absolute numbers but much more are run and a lot of exceptions extra. We'll have to revisit this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-896113649


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-865753216


   test_egress_fw_rules.py in a new env shows the new failure succeeding, skipping this test (for now):
   ```
   Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS ===
   ok
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-911516031


   @DaanHoogland pl create another PR to continue any further work. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-882427201


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 586


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-882398246


   the test_vpc_* failures show a failure to ssh into a vm or router or do a wget that fails.
   in python2 the wget gives no error but this seems a false positive. When removing the leanup from the tests the remaining envs do not allow for wget and on the marvin box a file named test.html remains with the contents,
   ```
   <html><body><h1>503 Service Unavailable</h1>
   No server is available to handle this request.
   </body></html>
   ```
   , indicating that the wget indeed failed even though the test reports success. I'm going to rebase the full test suites for both python2 and python3 and re-run the full comparison.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-908042841


   opening this for review now as travis job 2 and 4 are regulars in the failure lists and don't seem to have to do with any work here. The rest should be fine now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909230377


   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-910080101


   <b>Trillian test result (tid-1874)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 54761 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5082-t1874-kvm-centos7.zip
   Smoke tests completed. 90 look OK, 3 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_start_failure | `Error` | 61.25 | test_deploy_vm.py
   test_deploy_vm_volume_creation_failure | `Error` | 79.68 | test_deploy_vm.py
   test_vm_ha | `Error` | 67.11 | test_vm_ha.py
   test_vm_sync | `Error` | 132.83 | test_vm_sync.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909229913






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-903916149


   @DaanHoogland good work, +1 for the proposed approach


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-882398246


   the test_vpc_* failures show a failure to ssh into a vm or router or do a wget that fails.
   in python2 the wget gives no error but this seems a false positive. When removing the leanup from the tests the remaining envs do not allow for wget and on the marvin box a file named test.html remains with the contents,
   ```
   <html><body><h1>503 Service Unavailable</h1>
   No server is available to handle this request.
   </body></html>
   ```
   , indicating that the wget indeed failed even though the test reports success. I'm going to rebase the full test suites for both python2 and python3 and re-run the full comparison.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-902786011


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-888846274


   @GabrielBrascher @rhtyd I am running a new comparison between the py2 and py3 tests now, to verify we are at least at par. will let you know.
   can you please review?
   thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-890985618


   > * limit scope of the remaining component tests and fix that limited scope of tests, such that they pass for kvm/vmware/xenserver at least with adv zone (preferably the case of adv zone + SG too)
   
   this scope is not yet clear and I would like to do that in a future PR.
   
   > 
   > * move all failing tests that can't be fixed (takes another couple of years :) ) with a different attribute to be fixed in future
   
   good idea, will do
   
   > 
   > * add/update component tests that missing to Travis
   
   Travis is already taking a long time (and we are probably not like by travis or the rest of apache) Let's discuss this
   
   > 
   > * integrate fix BO to run component tests (that are known to pass), something like @bo test componentmatrix to kick component only tests across kvm/vmware/xenserver?
   
   yes, but this also seems a separate PR. (and internal to BO mostly, not ACS)
   
   thanks for the suggestions @rhtyd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-896927745


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 844


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-870323917


   Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-903527889


   @GabrielBrascher you are free to review now, btw. I just want to prevent merging when one of the component tests being used in travis might have a regression.
   
   @nvazquez @rhtyd I gathered the py2 and py3 outputs:
   ```
   09:45:14 [dahn@blimbing cloudstack]$ head -1 cts-*-py?.20210818
   09:48:57
   ==> cts-kvm-py2.20210818 <==
   Component tests completed. 105 look OK, 61 have errors
   
   ==> cts-kvm-py3.20210818 <==
   Component tests completed. 129 look OK, 31 have errors
   
   ==> cts-vmware-py2.20210818 <==
   Component tests completed. 51 look OK, 115 have errors
   
   ==> cts-vmware-py3.20210818 <==
   Component tests completed. 93 look OK, 67 have errors
   
   ==> cts-xen-py2.20210818 <==
   Component tests completed. 54 look OK, 113 have errors
   
   ==> cts-xen-py3.20210818 <==
   Component tests completed. 90 look OK, 70 have errors
   ```
   
   as y'all can see it is an improvements in all three hypervisor, but not done yet. I will now abandon testing the py2 versions all together and use these py3 results as my new baseline for further improvements. Any objections?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909255200


   <b>Trillian Build Failed (tid-1866)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-911514107


   LGTM as Gabriel and others have said let's merge this. We don't normally run component tests, but getting incremental PRs merged is a good approach. Smoketests on this have passed (the errors are not related to this PR, these are tests that shouldn't run).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-910051738


   <b>Trillian test result (tid-1873)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52415 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5082-t1873-xenserver-71.zip
   Smoke tests completed. 90 look OK, 3 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_start_failure | `Error` | 99.97 | test_deploy_vm.py
   test_deploy_vm_volume_creation_failure | `Error` | 87.69 | test_deploy_vm.py
   test_vm_ha | `Error` | 86.81 | test_vm_ha.py
   test_vm_sync | `Error` | 171.74 | test_vm_sync.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909235039






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909229913


   smoke tests and java code have not changed, but still:
   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-883197490


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 596


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-901747527


   ```
   ==> cts-kvm-py2.20210817 <==
   Component tests completed. 40 look OK, 126 have errors
   
   ==> cts-kvm-py3.20210817 <==
   Component tests completed. 125 look OK, 35 have errors
   
   ==> cts-vmware-py2.20210817 <==
   Component tests completed. 51 look OK, 115 have errors
   
   ==> cts-vmware-py3.20210817 <==
   Component tests completed. 91 look OK, 69 have errors
   
   ==> cts-xen-py2.20210817 <==
   Component tests completed. 54 look OK, 112 have errors
   
   ==> cts-xen-py3.20210817 <==
   Component tests completed. 89 look OK, 71 have errors
   ```
   re-running tests now as a lot of lab issues were encountered.
   so far kvm on python3 looks best followed by the other python3 runs, so basically we are in a better place than with the old python2 runs of the component tests.
   
   cc @nvazquez @rhtyd @GabrielBrascher, I can carry this on, but I feel this could be merged now as well, and the remaining work done in a new PR. What do you guys say?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-892593659


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 752


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-888383549


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909253447


   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909252917


   @blueorangutan test matrix keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-883197490


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 596


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909255846


   <b>Trillian Build Failed (tid-1864)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-903518715


   > @DaanHoogland should/could this one be placed as "ready for review"?
   
   Yes, If travis is running ok I will put it in review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-901900071


   @DaanHoogland should/could this one be placed as "ready for review"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-889738885


   Will review soon, but +1 great work @DaanHoogland we've always had components test but never run them. With your work, we finally wil have verified list of tests/cases that we expect to work which will further help with running such component tests on weekly basis to review/monitor branch health.
   
   I suppose there are still some work left but I would want to get something merged soon that could help 4.16, for example:
   - limit scope of the remaining component tests and fix that limited scope of tests, such that they pass for kvm/vmware/xenserver at least with adv zone (preferably the case of adv zone + SG too)
   - move all failing tests that can't be fixed (takes another couple of years :) ) with a different attribute to be fixed in future
   - add/update component tests that missing to Travis
   - integrate fix BO to run component tests (that are known to pass), something like @bo test componentmatrix to kick component only tests across kvm/vmware/xenserver?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-901898380


   @DaanHoogland I am OK with merging it how it is and open new PRs for remaining works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-872984869


   test_templates brought up to par; py2:
   ```
   Test create VM, Snapshot and Template ... === TestName: test_01_createVM_snapshotTemplate | Status : SUCCESS ===
   ok
   Test snapshot events ... === TestName: test_05_snapshot_events | Status : SUCCESS ===
   ok
   Test Creating snapshot from volume having spaces in name(KVM) ... === TestName: test_01_volume_from_snapshot | Status : FAILED ===
   FAIL
   Test Snapshot Data Disk ... === TestName: test_02_snapshot_data_disk | Status : SUCCESS ===
   ok
   Test snapshot from detached disk ... === TestName: test_03_snapshot_detachedDisk | Status : SUCCESS ===
   ok
   Test Delete Snapshot ... === TestName: test_04_delete_snapshot | Status : SUCCESS ===
   ok
   Create Template from snapshot ... === TestName: test_07_template_from_snapshot | Status : EXCEPTION ===
   ERROR
   ```
   
   and py3:
   ```
   Test create VM, Snapshot and Template ... === TestName: test_01_createVM_snapshotTemplate | Status : SUCCESS ===
   ok
   Test snapshot events ... === TestName: test_05_snapshot_events | Status : SUCCESS ===
   ok
   Test Creating snapshot from volume having spaces in name(KVM) ... === TestName: test_01_volume_from_snapshot | Status : FAILED ===
   FAIL
   Test Snapshot Data Disk ... === TestName: test_02_snapshot_data_disk | Status : SUCCESS ===
   ok
   Test snapshot from detached disk ... === TestName: test_03_snapshot_detachedDisk | Status : SUCCESS ===
   ok
   Test Delete Snapshot ... === TestName: test_04_delete_snapshot | Status : SUCCESS ===
   ok
   Create Template from snapshot ... === TestName: test_07_template_from_snapshot | Status : SUCCESS ===
   ok
   ```
   
   The failure is strange and I am not sure but I think it is in the test, have spent too much time on this one for now, and the goal is being on par with py2 for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-872120781


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-909412274


   @nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-870323917


   Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-908282720


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #5082: component test ports/fixes in python3

Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on pull request #5082:
URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-865753216


   test_egress_fw_rules.py in a new env shows the new failure succeeding, skipping this test (for now):
   
   ```
   Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS ===
   ok
   ```
   the difference in time in the first comparison is now an exception in py2 and still a failure in py3:
   ```
   Test egress rule with /32 CIDR of a VM, and check other VM in the ... === TestName: test_01_2_egress_fr1 | Status : EXCEPTION ===
   ERROR
   ```
   vs
   ```
   Test egress rule with /32 CIDR of a VM, and check other VM in the ... === TestName: test_01_2_egress_fr1 | Status : FAILED ===
   FAIL
   ```
   
   addendum; re-test succeeds:
   ```
   Test egress rule with /32 CIDR of a VM, and check other VM in the ... === TestName: test_01_2_egress_fr1 | Status : SUCCESS ===
   ok
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org