You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/03 01:41:48 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #24129: [SPARK-27190][SQL] add table capability for streaming

cloud-fan commented on a change in pull request #24129: [SPARK-27190][SQL] add table capability for streaming
URL: https://github.com/apache/spark/pull/24129#discussion_r271553638
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SupportsWrite.java
 ##########
 @@ -22,9 +22,10 @@
 import org.apache.spark.sql.util.CaseInsensitiveStringMap;
 
 /**
- * An internal base interface of mix-in interfaces for writable {@link Table}. This adds
- * {@link #newWriteBuilder(CaseInsensitiveStringMap)} that is used to create a write
- * for batch or streaming.
+ * A mix-in interface of {@link Table}, to indicate that it's readable.
 
 Review comment:
   We don't have a plan to introduce something similar to the `Table` API, I'd like to be clear right now and say this is a mix-trait for `Table`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org