You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.com> on 2017/01/18 19:00:52 UTC
Review Request 55678: Renamed `locateExecutor` to `getExecutor`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55678/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
Bugs: MESOS-6864
https://issues.apache.org/jira/browse/MESOS-6864
Repository: mesos
Description
-------
Rnamed `locateExecutor` to `getExecutor` in `slave.cpp` to be consistent
with other similar functions in the same file.
Diffs
-----
src/slave/http.cpp ee7119179a6ddd935c3f43a618ef645619c305ee
src/slave/slave.hpp 8c21ce95683b3d8f0f732e87cf3b3dbe7860f1da
src/slave/slave.cpp ae183e6b8b40094b4764525a6d63164f210ef9d8
Diff: https://reviews.apache.org/r/55678/diff/
Testing
-------
`make check` in macOS and Linux.
Thanks,
Gast�n Kleiman
Re: Review Request 55678: Renamed `locateExecutor` to `getExecutor`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55678/#review162288
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 19, 2017, 10:17 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55678/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 10:17 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6864
> https://issues.apache.org/jira/browse/MESOS-6864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rnamed `locateExecutor` to `getExecutor` in `slave.cpp` to be consistent
> with other similar functions in the same file.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ee7119179a6ddd935c3f43a618ef645619c305ee
> src/slave/slave.hpp 8c21ce95683b3d8f0f732e87cf3b3dbe7860f1da
> src/slave/slave.cpp 205138add7a63289ff8ed81138f8b603828c748e
>
> Diff: https://reviews.apache.org/r/55678/diff/
>
>
> Testing
> -------
>
> `make check` in macOS and Linux.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 55678: Renamed `locateExecutor` to `getExecutor`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55678/#review162282
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Jan. 19, 2017, 11:17 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55678/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 11:17 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6864
> https://issues.apache.org/jira/browse/MESOS-6864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rnamed `locateExecutor` to `getExecutor` in `slave.cpp` to be consistent
> with other similar functions in the same file.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ee7119179a6ddd935c3f43a618ef645619c305ee
> src/slave/slave.hpp 8c21ce95683b3d8f0f732e87cf3b3dbe7860f1da
> src/slave/slave.cpp 205138add7a63289ff8ed81138f8b603828c748e
>
> Diff: https://reviews.apache.org/r/55678/diff/
>
>
> Testing
> -------
>
> `make check` in macOS and Linux.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 55678: Renamed `locateExecutor` to `getExecutor`.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55678/#review162294
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Jan. 19, 2017, 10:17 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55678/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 10:17 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6864
> https://issues.apache.org/jira/browse/MESOS-6864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rnamed `locateExecutor` to `getExecutor` in `slave.cpp` to be consistent
> with other similar functions in the same file.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ee7119179a6ddd935c3f43a618ef645619c305ee
> src/slave/slave.hpp 8c21ce95683b3d8f0f732e87cf3b3dbe7860f1da
> src/slave/slave.cpp 205138add7a63289ff8ed81138f8b603828c748e
>
> Diff: https://reviews.apache.org/r/55678/diff/
>
>
> Testing
> -------
>
> `make check` in macOS and Linux.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 55678: Renamed `locateExecutor` to `getExecutor`.
Posted by Gastón Kleiman <ga...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55678/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 10:17 a.m.)
Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-6864
https://issues.apache.org/jira/browse/MESOS-6864
Repository: mesos
Description
-------
Rnamed `locateExecutor` to `getExecutor` in `slave.cpp` to be consistent
with other similar functions in the same file.
Diffs (updated)
-----
src/slave/http.cpp ee7119179a6ddd935c3f43a618ef645619c305ee
src/slave/slave.hpp 8c21ce95683b3d8f0f732e87cf3b3dbe7860f1da
src/slave/slave.cpp 205138add7a63289ff8ed81138f8b603828c748e
Diff: https://reviews.apache.org/r/55678/diff/
Testing
-------
`make check` in macOS and Linux.
Thanks,
Gast�n Kleiman