You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Francois Kritzinger (JIRA)" <ji...@apache.org> on 2012/10/22 16:24:11 UTC
[jira] [Created] (CAMEL-5732) Data coding of 0x02 not considered
8-bit
Francois Kritzinger created CAMEL-5732:
------------------------------------------
Summary: Data coding of 0x02 not considered 8-bit
Key: CAMEL-5732
URL: https://issues.apache.org/jira/browse/CAMEL-5732
Project: Camel
Issue Type: Bug
Components: camel-smpp
Reporter: Francois Kritzinger
SmppUtils.parseAlphabetFromDataCoding()) doesn't identify an input of 0x02 as 8-bit, but the SMPP spec (3.4 and 5.0) clearly states that 0x02 is octet-unspecified (8-bit).
The bug is actually in jsmpp, but the attached patch contains a workaround.
This seems like a pretty blatant mistake to make, so perhaps there is good explanation that I am not aware of?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5732) Data coding of 0x02 not considered
8-bit
Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482662#comment-13482662 ]
Christian Müller commented on CAMEL-5732:
-----------------------------------------
See chapter 5.2.19 data_coding in http://docs.nimta.com/SMPP_v3_4_Issue1_2.pdf
> Data coding of 0x02 not considered 8-bit
> ----------------------------------------
>
> Key: CAMEL-5732
> URL: https://issues.apache.org/jira/browse/CAMEL-5732
> Project: Camel
> Issue Type: Bug
> Components: camel-smpp
> Reporter: Francois Kritzinger
> Assignee: Christian Müller
> Attachments: dcs_of_2_is_8bit.diff
>
>
> SmppUtils.parseAlphabetFromDataCoding()) doesn't identify an input of 0x02 as 8-bit, but the SMPP spec (3.4 and 5.0) clearly states that 0x02 is octet-unspecified (8-bit).
> The bug is actually in jsmpp, but the attached patch contains a workaround.
> This seems like a pretty blatant mistake to make, so perhaps there is good explanation that I am not aware of?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-5732) Data coding of 0x02 not considered
8-bit
Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Müller reassigned CAMEL-5732:
---------------------------------------
Assignee: Christian Müller
> Data coding of 0x02 not considered 8-bit
> ----------------------------------------
>
> Key: CAMEL-5732
> URL: https://issues.apache.org/jira/browse/CAMEL-5732
> Project: Camel
> Issue Type: Bug
> Components: camel-smpp
> Reporter: Francois Kritzinger
> Assignee: Christian Müller
> Attachments: dcs_of_2_is_8bit.diff
>
>
> SmppUtils.parseAlphabetFromDataCoding()) doesn't identify an input of 0x02 as 8-bit, but the SMPP spec (3.4 and 5.0) clearly states that 0x02 is octet-unspecified (8-bit).
> The bug is actually in jsmpp, but the attached patch contains a workaround.
> This seems like a pretty blatant mistake to make, so perhaps there is good explanation that I am not aware of?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5732) Data coding of 0x02 not considered
8-bit
Posted by "Francois Kritzinger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francois Kritzinger updated CAMEL-5732:
---------------------------------------
Attachment: dcs_of_2_is_8bit.diff
> Data coding of 0x02 not considered 8-bit
> ----------------------------------------
>
> Key: CAMEL-5732
> URL: https://issues.apache.org/jira/browse/CAMEL-5732
> Project: Camel
> Issue Type: Bug
> Components: camel-smpp
> Reporter: Francois Kritzinger
> Attachments: dcs_of_2_is_8bit.diff
>
>
> SmppUtils.parseAlphabetFromDataCoding()) doesn't identify an input of 0x02 as 8-bit, but the SMPP spec (3.4 and 5.0) clearly states that 0x02 is octet-unspecified (8-bit).
> The bug is actually in jsmpp, but the attached patch contains a workaround.
> This seems like a pretty blatant mistake to make, so perhaps there is good explanation that I am not aware of?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5732) Data coding of 0x02 not considered
8-bit
Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482674#comment-13482674 ]
Christian Müller commented on CAMEL-5732:
-----------------------------------------
fixed some checkstyle issues which are raised by running
{code}
mvn clean install -Psourcecheck
{code}
This is documented here: http://camel.apache.org/building.html.
> Data coding of 0x02 not considered 8-bit
> ----------------------------------------
>
> Key: CAMEL-5732
> URL: https://issues.apache.org/jira/browse/CAMEL-5732
> Project: Camel
> Issue Type: Bug
> Components: camel-smpp
> Reporter: Francois Kritzinger
> Assignee: Christian Müller
> Attachments: dcs_of_2_is_8bit.diff
>
>
> SmppUtils.parseAlphabetFromDataCoding()) doesn't identify an input of 0x02 as 8-bit, but the SMPP spec (3.4 and 5.0) clearly states that 0x02 is octet-unspecified (8-bit).
> The bug is actually in jsmpp, but the attached patch contains a workaround.
> This seems like a pretty blatant mistake to make, so perhaps there is good explanation that I am not aware of?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5732) Data coding of 0x02 not considered
8-bit
Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Müller updated CAMEL-5732:
------------------------------------
Fix Version/s: 2.11.0
2.10.3
2.9.5
> Data coding of 0x02 not considered 8-bit
> ----------------------------------------
>
> Key: CAMEL-5732
> URL: https://issues.apache.org/jira/browse/CAMEL-5732
> Project: Camel
> Issue Type: Bug
> Components: camel-smpp
> Reporter: Francois Kritzinger
> Assignee: Christian Müller
> Fix For: 2.9.5, 2.10.3, 2.11.0
>
> Attachments: dcs_of_2_is_8bit.diff
>
>
> SmppUtils.parseAlphabetFromDataCoding()) doesn't identify an input of 0x02 as 8-bit, but the SMPP spec (3.4 and 5.0) clearly states that 0x02 is octet-unspecified (8-bit).
> The bug is actually in jsmpp, but the attached patch contains a workaround.
> This seems like a pretty blatant mistake to make, so perhaps there is good explanation that I am not aware of?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (CAMEL-5732) Data coding of 0x02 not considered
8-bit
Posted by "Christian Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Müller closed CAMEL-5732.
-----------------------------------
Resolution: Fixed
Thank you Francois for the patch! Feel free to test the SNAPSHOT versions.
> Data coding of 0x02 not considered 8-bit
> ----------------------------------------
>
> Key: CAMEL-5732
> URL: https://issues.apache.org/jira/browse/CAMEL-5732
> Project: Camel
> Issue Type: Bug
> Components: camel-smpp
> Reporter: Francois Kritzinger
> Assignee: Christian Müller
> Fix For: 2.9.5, 2.10.3, 2.11.0
>
> Attachments: dcs_of_2_is_8bit.diff
>
>
> SmppUtils.parseAlphabetFromDataCoding()) doesn't identify an input of 0x02 as 8-bit, but the SMPP spec (3.4 and 5.0) clearly states that 0x02 is octet-unspecified (8-bit).
> The bug is actually in jsmpp, but the attached patch contains a workaround.
> This seems like a pretty blatant mistake to make, so perhaps there is good explanation that I am not aware of?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira