You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2010/03/05 10:11:44 UTC

[jira] Created: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
--------------------------------------------------------------------------------------

                 Key: CAMEL-2526
                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
             Project: Apache Camel
          Issue Type: Improvement
          Components: camel-core
    Affects Versions: 2.2.0, 2.1.0, 2.0.0
            Reporter: Claus Ibsen
            Priority: Trivial
             Fix For: 2.3.0


If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58649#action_58649 ] 

Ashwin Karpe commented on CAMEL-2526:
-------------------------------------

Patch applied as revision r930358

> SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2526
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Trivial
>             Fix For: 2.3.0
>
>         Attachments: seda-maxconcurrentconsumers-2.patch, seda-maxconcurrentconsumers.patch
>
>
> If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
> We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58647#action_58647 ] 

Ashwin Karpe commented on CAMEL-2526:
-------------------------------------

Hi Claus,

No problem. I will make the changes you recommend and create another patch...

Cheers,

Ashwin...

> SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2526
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Trivial
>             Fix For: 2.3.0
>
>         Attachments: seda-maxconcurrentconsumers.patch
>
>
> If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
> We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe resolved CAMEL-2526.
---------------------------------

    Resolution: Fixed

Patch committed as revision r930313

> SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2526
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Trivial
>             Fix For: 2.3.0
>
>         Attachments: seda-maxconcurrentconsumers.patch
>
>
> If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
> We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58646#action_58646 ] 

Claus Ibsen commented on CAMEL-2526:
------------------------------------

Ashwin I think it should thrown an IllegalArgumentException if concurrentConsumers > max.

Logging at INFO level just get unnoticed. At least it should log at WARN level instead.
But I would prefer to IllegalArgumentException instead.

Then that option limitConcurrentConsumers can be used to bypass and then you can have 9999 if you really want.



> SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2526
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Trivial
>             Fix For: 2.3.0
>
>         Attachments: seda-maxconcurrentconsumers.patch
>
>
> If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
> We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe reassigned CAMEL-2526:
-----------------------------------

    Assignee: Ashwin Karpe

> SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2526
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Trivial
>             Fix For: 2.3.0
>
>
> If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
> We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-2526 started by Ashwin Karpe.

> SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2526
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Trivial
>             Fix For: 2.3.0
>
>
> If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
> We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe updated CAMEL-2526:
--------------------------------

    Attachment: seda-maxconcurrentconsumers-2.patch

Claus,

Please see the attached patch. I have changed it per your recommendation and tested it.

Cheers,

Ashwin...

> SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2526
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Trivial
>             Fix For: 2.3.0
>
>         Attachments: seda-maxconcurrentconsumers-2.patch, seda-maxconcurrentconsumers.patch
>
>
> If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
> We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-2526) SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes

Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashwin Karpe updated CAMEL-2526:
--------------------------------

    Attachment: seda-maxconcurrentconsumers.patch

Hi Claus,

Please find attached a patch for this issue. I have tested it and it works fine.

BTW, I also added a flag, just in case there was someone out there who wanted to explicitly bypass this setting. I have set the max concurrent consumers to 500 and added an info log message on the component to record the change in case there is a component that runs into this ceiling.

I will commit it to the trunk since it is a rather trivial fix.

Cheers,

Ashwin...

> SedaConsumer - Add check to limit the concurrentConsumer to < 1000 to prevent mistypes
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2526
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2526
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Trivial
>             Fix For: 2.3.0
>
>         Attachments: seda-maxconcurrentconsumers.patch
>
>
> If you enter concurrentConsumers=99999999 then Camel creates a lot of threads for concurrent consumers on the SEDA queue.
> We should validate the size is a reasonable value, at least < 1000. Maybe limit to < 500

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.