You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/28 15:53:41 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #7549:
[FLINK-11403][network] Introduce ResultPartitionWithConsumableNotifier in
task for notifying consumable result partition
azagrebin commented on a change in pull request #7549: [FLINK-11403][network] Introduce ResultPartitionWithConsumableNotifier in task for notifying consumable result partition
URL: https://github.com/apache/flink/pull/7549#discussion_r288164393
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -370,16 +370,26 @@ public Task(
final MetricGroup inputGroup = networkGroup.addGroup("Input");
// produced intermediate result partitions
- this.producedPartitions = networkEnvironment.createResultPartitionWriters(
+ ResultPartitionWriter[] partitionWriters = networkEnvironment.createResultPartitionWriters(
taskNameWithSubtaskAndId,
- jobId,
executionId,
- this,
- resultPartitionConsumableNotifier,
resultPartitionDeploymentDescriptors,
outputGroup,
buffersGroup);
+ int counter = 0;
+ this.producedPartitions = new ResultPartitionWriter[resultPartitionDeploymentDescriptors.size()];
+ for (ResultPartitionDeploymentDescriptor desc : resultPartitionDeploymentDescriptors) {
Review comment:
nit: suggest to move wrapping loop into a separate static method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services