[jira] [Commented] (FLINK-4148) incorrect calculation distance in QuadTree

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478750#comment-15478750 ] 

ASF GitHub Bot commented on FLINK-4148:
---------------------------------------

Github user nssalian commented on the issue:

    https://github.com/apache/flink/pull/2442
  
    Hi @xhumanoid , thanks for the PR. Could you please check the Failure messages and fix the build? Can help review once the PR is cleanly mergable.


> incorrect calculation distance in QuadTree
> ------------------------------------------
>
>                 Key: FLINK-4148
>                 URL: https://issues.apache.org/jira/browse/FLINK-4148
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Alexey Diomin
>            Priority: Trivial
>         Attachments: 0001-FLINK-4148-incorrect-calculation-minDist-distance-in.patch
>
>
> https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala#L105
> Because EuclideanDistanceMetric extends SquaredEuclideanDistanceMetric we always move in first case and never reach case for math.sqrt(minDist)
> correct match first EuclideanDistanceMetric and after it SquaredEuclideanDistanceMetric
> p.s. because EuclideanDistanceMetric more compute expensive and stay as default DistanceMetric it's can cause some performance degradation for KNN on default parameters



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)