You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/19 14:21:47 UTC
[GitHub] [doris] stalary opened a new pull request, #13497: [Bug](policy) Add readlock for show policy
stalary opened a new pull request, #13497:
URL: https://github.com/apache/doris/pull/13497
# Proposed changes
Issue Number: close https://github.com/apache/doris/issues/13482
## Problem summary
Add readlock for show policy resolve ConcurrentModificationException
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #13497: [Bug](policy) Add readlock for show policy
Posted by GitBox <gi...@apache.org>.
morningman merged PR #13497:
URL: https://github.com/apache/doris/pull/13497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #13497: [Bug](policy) Add readlock for show policy
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #13497:
URL: https://github.com/apache/doris/pull/13497#discussion_r1002617193
##########
fe/fe-core/src/main/java/org/apache/doris/policy/PolicyMgr.java:
##########
@@ -186,16 +200,25 @@ private boolean existPolicy(DropPolicyLog checkedDropPolicy) {
* @return Policy in typeToPolicyMap
*/
public Policy getPolicy(Policy checkedPolicy) {
- List<Policy> policies = getPoliciesByType(checkedPolicy.getType());
- for (Policy policy : policies) {
- if (policy.matchPolicy(checkedPolicy)) {
- return policy;
+ readLock();
+ try {
+ List<Policy> policies = getPoliciesByType(checkedPolicy.getType());
+ for (Policy policy : policies) {
+ if (policy.matchPolicy(checkedPolicy)) {
+ return policy;
+ }
}
+ return null;
+ } finally {
+ readUnlock();
}
- return null;
}
- public List<Policy> getPoliciesByType(PolicyTypeEnum policyType) {
+ public List<Policy> getCopiedPoliciesByType(PolicyTypeEnum policyType) {
Review Comment:
This should also be wrapped with readlock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13497: [Bug](policy) Add readlock for show policy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13497:
URL: https://github.com/apache/doris/pull/13497#issuecomment-1288306363
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13497: [Bug](policy) Add readlock for show policy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13497:
URL: https://github.com/apache/doris/pull/13497#issuecomment-1288306388
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org