You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/06 09:31:40 UTC

[GitHub] [flink] wuchong commented on a diff in pull request #20630: [FLINK-29023][docs][table] Updating Jar statement document

wuchong commented on code in PR #20630:
URL: https://github.com/apache/flink/pull/20630#discussion_r963481559


##########
docs/content/docs/dev/table/sql/jar.md:
##########
@@ -68,22 +70,24 @@ Flink SQL> REMOVE JAR '/path/hello.jar';
 ADD JAR '<path_to_filename>.jar'
 ```
 
-Currently it only supports to add the local jar into the session classloader.
+Currently it supports to add the jar locates in a local or remote [file system]({{< ref "docs/deployment/filesystems/overview" >}}) into the session classloader.
 
-## REMOVE JAR
+## SHOW JARS
 
 ```sql
-REMOVE JAR '<path_to_filename>.jar'
+SHOW JARS
 ```
 
-Currently it only supports to remove the jar that is added by the [`ADD JAR`](#add-jar) statements.
+Show all added jars in the session classloader which are added by [`ADD JAR`](#add-jar) and [`USING JAR`]({{< ref "docs/dev/table/sql/create" >}}#create-function) statements.

Review Comment:
   Why `SHOW JARS` also shows jars in `CREATE FUNCTION USING JAR`? The semantics of `SHOW/ADD/REMOVE JARS` seem not consistent to me. From my understanding, `SHOW JARS` should show the jars added to the session, but `CREATE FUNCTION USING JAR` doesn't affect the current session and functions with using jar referenced by queries are bound to the queries not sessions. 



##########
docs/content/docs/dev/table/sql/jar.md:
##########
@@ -68,22 +70,24 @@ Flink SQL> REMOVE JAR '/path/hello.jar';
 ADD JAR '<path_to_filename>.jar'
 ```
 
-Currently it only supports to add the local jar into the session classloader.
+Currently it supports to add the jar locates in a local or remote [file system]({{< ref "docs/deployment/filesystems/overview" >}}) into the session classloader.
 
-## REMOVE JAR
+## SHOW JARS
 
 ```sql
-REMOVE JAR '<path_to_filename>.jar'
+SHOW JARS
 ```
 
-Currently it only supports to remove the jar that is added by the [`ADD JAR`](#add-jar) statements.
+Show all added jars in the session classloader which are added by [`ADD JAR`](#add-jar) and [`USING JAR`]({{< ref "docs/dev/table/sql/create" >}}#create-function) statements.
 
-## SHOW JARS
+## REMOVE JAR
 
 ```sql
-SHOW JARS
+REMOVE JAR '<path_to_filename>.jar'
 ```
 
-Show all added jars in the session classloader which are added by [`ADD JAR`](#add-jar) statements.
+Currently it supports to remove the jar that is added by the [`ADD JAR`](#add-jar) and [`USING JAR`]({{< ref "docs/dev/table/sql/create" >}}#create-function) statements.

Review Comment:
   I'm a little confused that why and how does REMOVE JAR remove USING JAR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org