You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2016/03/07 05:29:02 UTC
Review Request 44436: LENS-919: Persist Query Priority in Lens DB
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/
-----------------------------------------------------------
Review request for lens.
Bugs: lens-919
https://issues.apache.org/jira/browse/lens-919
Repository: lens
Description
-------
As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4ed1827ee5094cbfd423c183766d9dc5f4
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d72989d7a8f9334adc81b82a9e0810ee39
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306ddef9baec65ee43e3880c9433791259dc
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
Diff: https://reviews.apache.org/r/44436/diff/
Testing
-------
Thanks,
Puneet Gupta
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Puneet Gupta <pu...@gmail.com>.
> On March 14, 2016, 9:52 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, lines 320-325
> > <https://reviews.apache.org/r/44436/diff/1/?file=1282194#file1282194line320>
> >
> > Should this test belong to `TestLensServerDAO`? reading a query from db and checking whether or not it has priority.
The other test metioned by you is already added to TestLensDAO. Here I wanted to do an end to end check. In both cases an existing test case has been updated
> On March 14, 2016, 9:52 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java, lines 173-176
> > <https://reviews.apache.org/r/44436/diff/1/?file=1282190#file1282190line173>
> >
> > Can't this be `Priority` instead of `String`?
> >
> > Not sure, but I probably enum fields might have direct handling from db.
I am not sure. We may be able to add some handlers, but it will be stored as string in DB.
Same handling is done for Status enum. Its stored as string
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review123393
-----------------------------------------------------------
On March 7, 2016, 4:30 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 4:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4ed1827ee5094cbfd423c183766d9dc5f4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d72989d7a8f9334adc81b82a9e0810ee39
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306ddef9baec65ee43e3880c9433791259dc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review123393
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java (lines 173 - 176)
<https://reviews.apache.org/r/44436/#comment185648>
Can't this be `Priority` instead of `String`?
Not sure, but I probably enum fields might have direct handling from db.
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (lines 320 - 325)
<https://reviews.apache.org/r/44436/#comment185651>
Should this test belong to `TestLensServerDAO`? reading a query from db and checking whether or not it has priority.
- Rajat Khandelwal
On March 7, 2016, 10 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 10 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4ed1827ee5094cbfd423c183766d9dc5f4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d72989d7a8f9334adc81b82a9e0810ee39
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306ddef9baec65ee43e3880c9433791259dc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review123638
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On March 15, 2016, 2:45 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 2:45 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java d447417
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 49ab241
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review123855
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1770)
<https://reviews.apache.org/r/44436/#comment186140>
Can we push the call to decidePriority to rewriteAndSelect itself ?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 2004)
<https://reviews.apache.org/r/44436/#comment186139>
This is happening after launch, which seems wrong.
- Amareshwari Sriramadasu
On March 15, 2016, 2:45 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 2:45 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java d447417
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 49ab241
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review123981
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 17, 2016, 2:17 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 2:17 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java f422543
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java d447417
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java ed97673
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 62ed293
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 49ab241
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/
-----------------------------------------------------------
(Updated March 17, 2016, 2:17 a.m.)
Review request for lens.
Changes
-------
1. Fixed Review comments .
2. Moved decidePriority() to AbstractQueryContext
3. Moved call to decidePriority in QueryExecutionServiceImpl to rewriteAndSelect()
Bugs: lens-919
https://issues.apache.org/jira/browse/lens-919
Repository: lens
Description
-------
As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java f422543
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java d447417
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java ed97673
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 62ed293
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 49ab241
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
Diff: https://reviews.apache.org/r/44436/diff/
Testing
-------
updated test cases to check for query priority and tested them
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
Results :
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Puneet Gupta
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/
-----------------------------------------------------------
(Updated March 15, 2016, 2:45 a.m.)
Review request for lens.
Changes
-------
1. Reason for test cases getting hung was "TestQueryService.testLaunchFail(MediaType)". In this case when the query fails to launch, the priority is null. The query purger is unable to create an instance of FinishedLensQuery. Added null handling for priority in FinishedLensQuery
Other changes
1. Added call to decidePriority() in QueryExecutionServiceImpl as it was missing for prepared quries and sync queries
2. AbstractLensDriver.decidePriority() will default to Priority.NORMAL
3. Changed logic in test case to check if the query is purged or not
Bugs: lens-919
https://issues.apache.org/jira/browse/lens-919
Repository: lens
Description
-------
As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java d447417
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 49ab241
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa68
Diff: https://reviews.apache.org/r/44436/diff/
Testing
-------
updated test cases to check for query priority and tested them
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
Results :
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Puneet Gupta
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Puneet Gupta <pu...@gmail.com>.
> On March 8, 2016, 11:42 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java, line 84
> > <https://reviews.apache.org/r/44436/diff/1/?file=1282192#file1282192line84>
> >
> > Do we need to **alter the table with new column** in case of finished_queries exists?
I think this scenario is not been handled for any additions/alterations until now . As of now for existing setups, we are manually altering the table.
We can create a new JIRA to handle all alter cases. There we can run a set of alter scripts (but it can be more complex if we allow upgrade from any old version to any new version).
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review122501
-----------------------------------------------------------
On March 7, 2016, 4:30 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 4:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4ed1827ee5094cbfd423c183766d9dc5f4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d72989d7a8f9334adc81b82a9e0810ee39
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306ddef9baec65ee43e3880c9433791259dc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 8, 2016, 5:12 p.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java, line 84
> > <https://reviews.apache.org/r/44436/diff/1/?file=1282192#file1282192line84>
> >
> > Do we need to **alter the table with new column** in case of finished_queries exists?
>
> Puneet Gupta wrote:
> I think this scenario is not been handled for any additions/alterations until now . As of now for existing setups, we are manually altering the table.
> We can create a new JIRA to handle all alter cases. There we can run a set of alter scripts (but it can be more complex if we allow upgrade from any old version to any new version).
Yes, we haven't yet provided any upgrade scripts. I think that is very difficult without using any ORM tool.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review122501
-----------------------------------------------------------
On March 7, 2016, 10 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 10 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4ed1827ee5094cbfd423c183766d9dc5f4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d72989d7a8f9334adc81b82a9e0810ee39
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306ddef9baec65ee43e3880c9433791259dc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review122501
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 84)
<https://reviews.apache.org/r/44436/#comment184550>
Do we need to **alter the table with new column** in case of finished_queries exists?
- Raju Bairishetti
On March 7, 2016, 4:30 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 4:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4ed1827ee5094cbfd423c183766d9dc5f4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d72989d7a8f9334adc81b82a9e0810ee39
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306ddef9baec65ee43e3880c9433791259dc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/#review123129
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 322)
<https://reviews.apache.org/r/44436/#comment185298>
Did not understand, how we are checking whether query is purged or not (i.e reading priority from DB)?
Overall changes looks good to me... +1
- Raju Bairishetti
On March 7, 2016, 4:30 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44436/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 4:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: lens-919
> https://issues.apache.org/jira/browse/lens-919
>
>
> Repository: lens
>
>
> Description
> -------
>
> As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4ed1827ee5094cbfd423c183766d9dc5f4
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d72989d7a8f9334adc81b82a9e0810ee39
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306ddef9baec65ee43e3880c9433791259dc
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
>
> Diff: https://reviews.apache.org/r/44436/diff/
>
>
> Testing
> -------
>
> updated test cases to check for query priority and tested them
>
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
>
> Results :
>
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 44436: LENS-919: Persist Query Priority in Lens DB
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44436/
-----------------------------------------------------------
(Updated March 7, 2016, 4:30 a.m.)
Review request for lens.
Bugs: lens-919
https://issues.apache.org/jira/browse/lens-919
Repository: lens
Description
-------
As of now Query Priority is not persisted. The query details API shows query priority only until query is in memory. Once purged this info is not available .
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java a57a6e4ed1827ee5094cbfd423c183766d9dc5f4
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java d8e654d72989d7a8f9334adc81b82a9e0810ee39
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 760e306ddef9baec65ee43e3880c9433791259dc
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
Diff: https://reviews.apache.org/r/44436/diff/
Testing (updated)
-------
updated test cases to check for query priority and tested them
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.063 sec - in org.apache.lens.server.query.TestQueryService
Results :
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Puneet Gupta