You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/10 11:51:57 UTC

[GitHub] [pulsar] 315157973 commented on a change in pull request #12721: Even if always compatible is set, Consumers cannot be created

315157973 commented on a change in pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721#discussion_r746514279



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
##########
@@ -270,6 +270,9 @@ private void checkCompatible(SchemaAndMetadata existingSchema, SchemaData newSch
     @Override
     public CompletableFuture<Void> checkConsumerCompatibility(String schemaId, SchemaData schemaData,
                                                               SchemaCompatibilityStrategy strategy) {
+        if (SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE.equals(strategy)) {

Review comment:
       ![image](https://user-images.githubusercontent.com/9758905/141108064-34ea301a-c73d-4e3c-a252-abea9b3234eb.png)
   
   What is the difference ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org