[GitHub] [tinkerpop] mikepersonick commented on a change in pull request #1545: Orderability Semantics (final)

[GitBox <gi...@apache.org>]

mikepersonick commented on a change in pull request #1545:
URL: https://github.com/apache/tinkerpop/pull/1545#discussion_r783106049



##########
File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/Graph.java
##########
@@ -61,13 +61,13 @@
     /**
      * Configuration key used by {@link GraphFactory}} to determine which graph to instantiate.
      */
-    public static final String GRAPH = "gremlin.graph";
+    String GRAPH = "gremlin.graph";
 
     /**
      * This should only be used by providers to create keys, labels, etc. in a namespace safe from users.
      * Users are not allowed to generate property keys, step labels, etc. that are key'd "hidden".
      */
-    public static class Hidden {
+    class Hidden {

Review comment:
       I did not restrict the scope. I can revert the changes but all those publics and statics were redundant, since they are inside a public interface. 
   
   I also added a new GraphFeature for OrderabilitySemantics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org